-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add escrow payment and allocate to recipient ContractSupport Helper #993
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a correction on an internal comment. otherwise, LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert that last change. It isn't quite what I have in mind, and the previous state is a better starting point. I also am not certain the refactoring I have in mind works.
Since the code as currently written is correct and follows the style of other approved code, I'm gonna say LGTM without this last commit. Approved to merge.
Then, when we have the time, let's look at refactorings of this pattern.
If i recall correctly, the opera ticket contract and autoswap were users of the previous pattern and should benefit from the new helper I don't have an opinion on whether this work should be done as part of this PR or a folow-up one |
Good idea. I like including their changes in this PR. |
Meta note: since this is adding a helper that hackathon participants probably need ASAP, and is not changing the Zoe API, I'm going to keep the base on this as |
61bb1ef
to
09830a8
Compare
@erights, I had to make two bug fixes in the latest commit: Offer Safety Check with Sparse Keywords#1012 updateAmounts with Sparse Keywords#1013 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…t to use escrowAndAllocateTo helper
235a8f5
to
41b6c9d
Compare
Closes #992
Closes #1010
Closes #1012
Closes #1013