Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: getVBankAssetInfo() on orch.getChain('agoric') #9798

Merged
merged 4 commits into from
Aug 2, 2024

Conversation

dckc
Copy link
Member

@dckc dckc commented Jul 29, 2024

refs: #9541, #9322, #9519

Description

add getVBankAssetInfo() method on agoric chain object.

DRAFT until

  • how to add chain-specific methods to return type of getChain()?
  • refactor uses of makeResumableAgoricNamesHack to use this

Documentation Considerations

change is visible via orchestration-api.d.ts
cc @dtribble

Security Considerations

none?

Scaling Considerations

returns O(n) data from O(1) args

Testing Considerations

perhaps not independently tested

Upgrade Considerations

not yet deployed

@dckc dckc requested a review from turadg July 29, 2024 19:35
Copy link

cloudflare-workers-and-pages bot commented Jul 29, 2024

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: a06ffde
Status: ✅  Deploy successful!
Preview URL: https://d5f4d6ac.agoric-sdk.pages.dev
Branch Preview URL: https://dc-vbank-ag-chain.agoric-sdk.pages.dev

View logs

Copy link
Member

@turadg turadg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

glad to see it

packages/orchestration/src/exos/local-chain-facade.js Outdated Show resolved Hide resolved
packages/orchestration/src/exos/local-chain-facade.js Outdated Show resolved Hide resolved
@dckc dckc force-pushed the dc-vbank-ag-chain branch 2 times, most recently from ffff61a to ad89f4a Compare July 29, 2024 23:23
@dckc dckc requested a review from 0xpatrickdev July 29, 2024 23:24
@dckc dckc marked this pull request as ready for review July 29, 2024 23:24
@dckc dckc requested a review from turadg July 29, 2024 23:24
@dckc dckc changed the title feat: getVBankAssets() on orc.getChain('agoric') (WIP) feat: getVBankAssets() on orc.getChain('agoric') Jul 29, 2024
@dckc dckc changed the title feat: getVBankAssets() on orc.getChain('agoric') feat: getVBankAssets() on orch.getChain('agoric') Jul 29, 2024
packages/orchestration/src/orchestration-api.ts Outdated Show resolved Hide resolved
packages/orchestration/src/exos/local-chain-facade.js Outdated Show resolved Hide resolved
packages/orchestration/src/exos/local-chain-facade.js Outdated Show resolved Hide resolved
packages/orchestration/src/examples/sendAnywhere.flows.js Outdated Show resolved Hide resolved
@dckc dckc mentioned this pull request Jul 30, 2024
@dckc dckc changed the title feat: getVBankAssets() on orch.getChain('agoric') feat: getVBankAssetInfo() on orch.getChain('agoric') Jul 31, 2024
@dckc dckc requested a review from turadg July 31, 2024 00:27
@dckc dckc added the automerge:rebase Automatically rebase updates, then merge label Jul 31, 2024
@dckc dckc force-pushed the dc-vbank-ag-chain branch 2 times, most recently from a3f6b73 to 590dd03 Compare July 31, 2024 14:53
@dckc dckc force-pushed the dc-vbank-ag-chain branch 2 times, most recently from 041230d to 8257e9c Compare July 31, 2024 22:36
@mergify mergify bot merged commit 5cd99ea into master Aug 2, 2024
79 checks passed
@mergify mergify bot deleted the dc-vbank-ag-chain branch August 2, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants