auction scheduler robustness #9759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9759 +/- ##
==========================================
- Coverage 56.37% 55.83% -0.55%
==========================================
Files 667 656 -11
Lines 207560 208436 +876
Branches 343 360 +17
==========================================
- Hits 117022 116374 -648
- Misses 90420 91942 +1522
- Partials 118 120 +2
|
dckc
approved these changes
Jul 23, 2024
| @@ -158,17 +158,26 @@ const divideHelper = (amount, ratio, divideOp) => { | |||
| ); | |||
| }; | |||
|
|
|||
| /** @type {ScaleAmount} */ | |||
| /** | |||
| * Divide the amount by the ratio, truncating the remainder. | |||
There was a problem hiding this comment.
an @example would be nice. I wonder how to do them concisely...
const a = withAmountUtils(makeIssuerKit('A'));
const double = makeRatio(2n, a.brand, 1n);
t.deepEqual(floorDivideBy(a.make(5n), double), a.make(2n));
|
Nicely done. Thanks for investigating and making this PR. What worries me still is that a similar math bug nearby will cause the same problem in a different way. I want to look for a repair that makes the auction not die when this happens. |
Deploying agoric-sdk with
|
| Latest commit: |
e9e637c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://09f9f19d.agoric-sdk.pages.dev |
| Branch Preview URL: | https://ta-auction-test.agoric-sdk.pages.dev |
turadg
force-pushed
the
ta/auction-test
branch
from
d4d7f42
to
e9e637c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
incidental
Description
Refactors the auction amount math out of the auction book and adds unit tests. I noticed an inconsistency so this adds an assertion to prevent that and a fix. Also a bunch of refactorings and docs to try to make this area of the code more clear.
Reviewers, review by commit is recommended.
Security Considerations
The auction book now calls out to another module to do the math. Module from its own package though.
Scaling Considerations
no change
Documentation Considerations
not user facing
Testing Considerations
regression test
Upgrade Considerations
This won't go out until VaultFactory gets a new auctioneer. See,
@Chris-Hibbert is working on the CoreEval and its test to deploy this