misc Orchestration cleanup #9720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
e8d0a7f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7585d466.agoric-sdk.pages.dev |
| Branch Preview URL: | https://9303-misc.agoric-sdk.pages.dev |
dckc
approved these changes
Jul 16, 2024
| @@ -35,9 +35,6 @@ export const Proto3Shape = { | |||
| value: M.string(), | |||
| }; | |||
|
|
|||
| // XXX same as ChainAmountShape and DenomAmount type | |||
| export const CoinShape = { value: M.bigint(), denom: M.string() }; | |||
Comment on lines
+20
to
+27
| * @template {(orc: Orchestrator, ctx: any, ...args: any[]) => Promise<any>} GF | ||
| * @typedef {GF extends ( | ||
| * orc: Orchestrator, | ||
| * ctx: any, | ||
| * ...args: infer GA | ||
| * ) => Promise<infer GR> | ||
| * ? (...args: HostArgs<GA>) => Vow<GR> | ||
| * : never} HostForGuest |
There was a problem hiding this comment.
this is at the edge of my tsc-fu; an example in the form of a type test would help me.
There was a problem hiding this comment.
worthwhile. probably another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
incidental
Description
Miscellaneous cleanups while starting #9719 for #9303.
See each commit title for changes
Security Considerations
none
Scaling Considerations
none
Documentation Considerations
none
Testing Considerations
CI
Upgrade Considerations
not yet deployed