Dt/retriable spike3 #9657
Draft
Dt/retriable spike3 #9657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
b46f590
|
| Status: | 🚫 Build failed. |
* add `retriable` to `vowTools` * turn warning of returned promise into an error * make `withFromSeat` an endowment
Co-authored-by: Mark S. Miller <erights@users.noreply.github.com>
In progress
* restore agoric-names-tools * update the zone architecture * introduce the `contract` zone for user names
dtribble
force-pushed
the
dt/retriable-spike3
branch
from
4715a1e
to
2ece7a9
Compare
This was referenced Jul 8, 2024
mergify bot
added a commit
that referenced
this pull request
Jul 9, 2024
refs: #9449 ## Description This makes ChainHub return durable vows. The underlying lookup functions are not durable but they made so by the `retriable` helper. So this also introduces a stub version of #9541 pulled from @dtribble 's #9657 ### Security Considerations none ### Scaling Considerations none ### Documentation Considerations none ### Testing Considerations CI ### Upgrade Considerations not yet upgradable. Communicated by https://github.com/Agoric/agoric-sdk/blob/a267ba20db0eeb2082c287ca7b69e37d6f272eb9/packages/vow/src/tools.js#L37-L38
mergify bot
added a commit
that referenced
this pull request
Jul 9, 2024
_incidental_ ## Description `provideOrchestration` sought to bundle up all the boilerplate. @mhofman suggested an even cleaner bundling: `withOrchestration`. This lets the contract function ignore the privateArgs powers entirely and get a zone instead of baggage. This makes that change, which required a name for the orchestration tools being provided. `OrchestrationTools` was the natural name but was used by a service for ICA accounts. @0xpatrickdev had some ideas for improving those names so this incorporates that as well. It also rearranges the zone as @dtribble had in #9657 ### Security Considerations Requires handing full privateArgs to the `withOrchestration` helper. It's not a great habit to hand everything out of module scope but this is a well vetted utility. Eventually we expect to provide some of these abilities on the ZCF. ### Scaling Considerations none ### Documentation Considerations none ### Testing Considerations CI. ### Upgrade Considerations Not yet deployed
mergify bot
added a commit
that referenced
this pull request
Jul 10, 2024
refs: #9449 ## Description Adapted from #9657 . The `retriable` helper and `withOrchestration` refactor landed already. This has the rest: - orchestrateAll helper - separate module for flows - ZoeTools endowment (for `withdrawFromSeat` à la #9449 ) - makeOrchestrator abstraction ### Security Considerations `orchestrateAll` grants the same context to each orchFn. If they have to be different, the author can make multiple calls grouping what is the same. Improves POLA of some Orchestration services by passing a `makeOrchestrator`. ### Scaling Considerations none ### Documentation Considerations none yet ### Testing Considerations CI ### Upgrade Considerations not yet deployed
turadg
reviewed
Aug 31, 2024
turadg
reviewed
Aug 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #9541
retriableto vowToolswithdrawFromSeatwith a transfer-to-local operation as an endowmentretriableforfindBrandInVBank