fix: revive the ability of a zoe client to get access to the code. #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katelynsills
reviewed
Apr 9, 2020
| @@ -321,7 +321,7 @@ const makeZoe = (additionalEndowments = {}) => { | |||
| } | |||
| } | |||
| const installationHandle = installationTable.create( | |||
| harden({ installation }), | |||
| harden({ installation, code }), | |||
There was a problem hiding this comment.
What's the difference between the installation and the code?
There was a problem hiding this comment.
code is a string with the actual source code. installation is the result of evaluating the code with all the context it needs. It's an object with a makeContract() function. That function has a bunch of metering wrappers thrown in, so it's not a useful place for clients to get access to and compare the code they are expecting to see.
erights
previously requested changes
Apr 9, 2020
It's tested in an existing large test by checking for specific text in the source code. We could check something less fragile (e.g. starts with 'function getExport'), and still be pretty sure that if a string is returned, it would continue to be the source of the contract. fixes #877
Chris-Hibbert
force-pushed
the
877-zoeCodeAccess
branch
from
ea64ac1
to
1ad9265
Compare
Chris-Hibbert
dismissed
erights’s stale review
made the requested change to a comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's tested in an existing large test by checking for specific text in
the source code. We could check something less fragile (e.g. starts
with 'function getExport'), and still be pretty sure that if a string
is returned, it would continue to be the source of the contract.
fixes #877