Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(cosmos/x/vstorage): Add README sections for CLI and "REST" API interfaces #8134

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

gibson042
Copy link
Member

No description provided.

Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with one recommended formatting change.

## External JSON interface

As described at [Cosmos SDK: Using the REST Endpoints](https://docs.cosmos.network/main/run-node/interact-node#using-the-rest-endpoints), a blockchain node whose [`app.toml` configuration](https://docs.cosmos.network/main/run-node/run-node#configuring-the-node-using-apptoml-and-configtoml) enables the "REST" API server uses [gRPC-Gateway](https://grpc-ecosystem.github.io/grpc-gateway/) and `google.api.http` annotations in [vstorage/query.proto](../../proto/agoric/vstorage/query.proto) to automatically translate the protobuf-based RPC endpoints into URL paths that accept query parameters and emit JSON.
* /agoric/vstorage/capdata/$path?remotableValueFormat={object,string}[&mediaType=JSON%20Lines][&itemFormat=flat]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably quote this example (and the two bullets below, for consistency), or else the square brackets are interpreted by Markdown.

Suggested change
* /agoric/vstorage/capdata/$path?remotableValueFormat={object,string}[&mediaType=JSON%20Lines][&itemFormat=flat]
* `/agoric/vstorage/capdata/$path?remotableValueFormat={object,string}[&mediaType=JSON%20Lines][&itemFormat=flat]`

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isolated square brackets have no special meaning in Markdown, so I left this. But if you see a problem, we can change it in a followup.

@gibson042 gibson042 added this pull request to the merge queue Aug 2, 2023
Merged via the queue into master with commit b4ce02d Aug 2, 2023
59 checks passed
@gibson042 gibson042 deleted the gibson-8056-followup-3 branch August 2, 2023 22:47
mhofman pushed a commit that referenced this pull request Aug 7, 2023
docs(cosmos/x/vstorage): Add README sections for CLI and "REST" API interfaces
mhofman pushed a commit that referenced this pull request Feb 18, 2024
docs(cosmos/x/vstorage): Add README sections for CLI and "REST" API interfaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants