minimum bid for auction #7210
Merged
minimum bid for auction #7210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arirubinstein
approved these changes
Mar 22, 2023
Chris-Hibbert
approved these changes
Mar 22, 2023
|
Getting this to pass the bootstrap test requires new test supports from #7028 so I'll land this after that. |
turadg
added
the
automerge:no-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ran into an error in Agoric/wallet-app#62 because the give was 0.0. This adds a minimum bid so that the offer isn't trivially fulfilled.
Security Considerations
Ensures there is some expense to adding a bid. I think previously someone could flood the order book without paying.
We may want to increase the minimum bid amount.
Scaling Considerations
--
Documentation Considerations
--
Testing Considerations
CI