Freshen the simple exchange dApp #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refs #646 It should at least compile, deploy, and run.
Chris-Hibbert
approved these changes
Mar 12, 2020
katelynsills
approved these changes
Mar 12, 2020
| // ===================== | ||
|
|
||
| // 5. Offer rules | ||
| const [unit0, unit1] = await Promise.all([ |
There was a problem hiding this comment.
This code was creating the initial liquidity. Are we doing that elsewhere?
There was a problem hiding this comment.
Does simple-exchange need liquidity? I didn't know that.
There was a problem hiding this comment.
It could benefit from some initial orders in the order book in the same way that we added liquidity to autoswap. It will still work without seeding with initial orders, but will be a worse user experience.
There was a problem hiding this comment.
That's a good idea. I'll make this work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #646
It should at least compile, deploy, and run.