Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(notifier): Add makeNotifierFromSubscriber #5737

Merged
merged 8 commits into from
Jul 14, 2022
Merged

feat(notifier): Add makeNotifierFromSubscriber #5737

merged 8 commits into from
Jul 14, 2022

Commits on Jul 8, 2022

  1. fix(notifier): Make makeAsyncIterableFromNotifier lossy 

    Cherry-picked from gh-5413-lossy-makeNotifierFromAsyncIterable.
See #5695 .
    @gibson042
    gibson042 committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    8ff8718 View commit details
    Browse the repository at this point in the history

  2. fix(notifier): Revert "Make makeAsyncIterableFromNotifier lossy" 

    Eager consumption led to infinite loops; see
#5695 for context.
    @gibson042
    gibson042 committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    923993f View commit details
    Browse the repository at this point in the history

  3. feat(notifier): Add makeNotifierFromSubscriber 

    Fixes #5413
    @gibson042
    gibson042 committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    e92402c View commit details
    Browse the repository at this point in the history

  4. test(notifier): Update per code review

    @gibson042
    gibson042 committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    f40b7ed View commit details
    Browse the repository at this point in the history

  5. chore(notifier): Resolve lint warnings

    @gibson042
    gibson042 committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    840ffda View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2022

  1. fix(notifier): Align makeNotifierFromSubscriber with makeNotifierKit 

    getUpdateSince() always consults the source subscribeAfter() rather than
using a possibly-stale local cache.
    @gibson042
    gibson042 committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    7a37ca5 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2022

  1. Merge branch 'master' into gh-5413-makeNotifierFromSubscriber

    @mergify
    mergify[bot] committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    a84d6c8 View commit details
    Browse the repository at this point in the history

  2. fix master merge

    @turadg
    turadg committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    ee307b3 View commit details
    Browse the repository at this point in the history