Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: represent storage in same order in genesis state #4147

Merged
merged 1 commit into from
Dec 2, 2021

Conversation

JimLarson
Copy link
Contributor

refs: #4134

Description

Similar to #4137, make the order of storage entries deterministic in the swingset genesis state.

This has no effect on operation of the chain, but should make it easier to compare different genesis states created by different nodes.

Security Considerations

None.

Documentation Considerations

N/A

Testing Considerations

N/A

@JimLarson JimLarson self-assigned this Dec 2, 2021
Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this!

@michaelfig michaelfig added the automerge:no-update (expert!) Automatically merge without updates label Dec 2, 2021
@mergify mergify bot merged commit 2ec95eb into master Dec 2, 2021
@mergify mergify bot deleted the 4134-swingset-genesis branch December 2, 2021 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:no-update (expert!) Automatically merge without updates cosmic-swingset package: cosmic-swingset
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants