-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(release): publish 10.0.0 #3970
Conversation
- @agoric/sdk@10.0.0 - @agoric/cosmos@0.27.0 - @agoric/ertp@0.12.2 - @agoric/swingset-vat@0.23.0 - @agoric/access-token@0.4.15 - agoric@0.13.19 - @agoric/assert@0.3.14 - @agoric/bundle-source@2.0.0 - @agoric/captp@1.10.6 - @agoric/cosmic-swingset@0.34.2 - @agoric/dapp-svelte-wallet@0.11.5 - @agoric/deploy-script-support@0.5.5 - @agoric/deployment@1.29.1 - @agoric/eslint-config@0.3.21 - @agoric/eventual-send@0.13.30 - @agoric/governance@0.3.0 - @agoric/import-bundle@0.2.31 - @agoric/import-manager@0.2.31 - @agoric/install-metering-and-ses@0.2.28 - @agoric/install-ses@0.5.28 - @agoric/marshal@0.4.28 - @agoric/notifier@0.3.31 - @agoric/pegasus@0.4.5 - @agoric/promise-kit@0.2.28 - @agoric/same-structure@0.1.28 - @agoric/sharing-service@0.1.31 - @agoric/solo@0.5.2 - @agoric/sparse-ints@0.1.24 - @agoric/spawner@0.4.31 - @agoric/stat-logger@0.4.24 - @agoric/store@0.6.6 - @agoric/swing-store@0.6.2 - @agoric/swingset-runner@0.17.2 - @agoric/tame-metering@2.0.14 - @agoric/transform-metering@1.4.27 - @agoric/treasury@0.6.5 - @agoric/ui-components@0.2.26 - @agoric/vats@0.4.2 - @agoric/wallet-connection@0.1.1 - @agoric/xsnap@0.10.0 - @agoric/zoe@0.20.0 - @agoric/dapp-svelte-wallet-api@0.10.5 - @agoric/dapp-react-wallet-ui@0.0.2 - @agoric/dapp-svelte-wallet-ui@1.10.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the system works. I note that bundle-source got a major ramp and governance got a minor for breaking changes as expected (among others) and these all render properly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks straightforward.
My comments fall under the category of wishing for better use of conventional commits and commit headlines.
* **governance:** export buildParamManager from index.js ([#3952](https://github.com/Agoric/agoric-sdk/issues/3952)) ([868964e](https://github.com/Agoric/agoric-sdk/commit/868964e09cac570cceda4617fd0723a0a64d1841)) | ||
* don't use manual key prefix ([50a881b](https://github.com/Agoric/agoric-sdk/commit/50a881be4971cd5c006867daca66eb6138276492)) | ||
* **SwingSet:** Adjust SES change detectors ([3efb36e](https://github.com/Agoric/agoric-sdk/commit/3efb36eb48521aeb9479f27bd691be485ecda234)) | ||
* **transform-meter:** Accommodate SES module proxies in meter ([9f7d456](https://github.com/Agoric/agoric-sdk/commit/9f7d45602c9d3c0a25729f97c2be8004230cb028)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
boring... we're still maintaining transform-meter
(boring = interest on technical debt. do we have an issue with the technical-debt label for this? I don't suppose it's cost-effective to go searching just now...)
* ContractGovernor manages parameter updating for a contract ([#3448](https://github.com/Agoric/agoric-sdk/issues/3448)) ([59ebde2](https://github.com/Agoric/agoric-sdk/commit/59ebde27708c0b3988f62a3626f9b092e148671f)) | ||
* revise x/lien to hold total liened amount ([842c9b0](https://github.com/Agoric/agoric-sdk/commit/842c9b0d98a8655b286c9f91c70bb6fddc3e0ba3)) | ||
* stateless lien module that upcalls to kernel ([603c0cf](https://github.com/Agoric/agoric-sdk/commit/603c0cfc8d2b4706dbbaa42d2ae057fa9dea65dc)) | ||
* **wallet:** Create react ui scaffold with ses ([#3879](https://github.com/Agoric/agoric-sdk/issues/3879)) ([089c876](https://github.com/Agoric/agoric-sdk/commit/089c876d801efc1ede76b3011a1301384aace77f)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Create react ui scaffold with ses" seems more like a chore. I'd like to see feat
used only for end-user-visible feature additions (the end user may be a developer, i.e. an API consumer). There are lots more cases of this; I'm just noting one.
|
||
* "yarn lint" should not fix ([#3943](https://github.com/Agoric/agoric-sdk/issues/3943)) ([0aca432](https://github.com/Agoric/agoric-sdk/commit/0aca432ed7a3f33eed4575b36dc3fa9e023b445f)) | ||
* adapt timers to async iterables ([#3949](https://github.com/Agoric/agoric-sdk/issues/3949)) ([9739127](https://github.com/Agoric/agoric-sdk/commit/9739127262e9fac48757094a4d2d9f3f35f4bfc5)) | ||
* address review comments ([8af3e15](https://github.com/Agoric/agoric-sdk/commit/8af3e1547b4df32c604f6b628a62bff230666166)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"address review comments" is one of my least favorite commit headlines. Surely if the comments were worth addressing, there are two or three words to say what they were about. Or more likely: this wasn't really a fix to a bug that was ever on master, and it should have been squashed or tagged chore
or style
rather than fix
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. I do occasionally post commits with this message and try to remember to squash them before merging. I know @erights in particular prefers to review these commits incrementally.
@kriskowal This is in the "Up Next" pipeline, but does not have a MN-1 label. If it is needed for MN-1, please label, otherwise move from "Up Next" to "Product Backlog". |
This is appearing as a completed dependency of #3859, which should remain in scope for MN-1. |
Packages that have NEWS.md updates