Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: XS + SES snapshots are deterministic (test) #3781

Merged
merged 5 commits into from
Sep 2, 2021

Conversation

dckc
Copy link
Member

@dckc dckc commented Aug 31, 2021

It's not entirely clear how this got fixed, but it no longer fails.

fixes #2776

@dckc
Copy link
Member Author

dckc commented Aug 31, 2021

@kriskowal do me a favor and test this on a mac?

Copy link
Member

@warner warner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent.

We should maybe add a note about when the new test will need to be updated. I think any change in SES will require updating the hashes, also any change in the xsnap.js initialization code.

Also, this test is a bit awkward here in packages/solo/ .. I think we put it here because the snapStore was hard to build from somewhere else, but now that packages/swing-store has been consolidated, is that still true? Can we move it to packages/SwingSet/ or packages/xsnap?

@dckc
Copy link
Member Author

dckc commented Sep 2, 2021

... Can we move it to packages/SwingSet/ or packages/xsnap?

I think we can move it to SwingSet. It passed a local smoke test. Let's see if the ci bot agrees.

I'd rather not add a dependency from xsnap to swing-store, especially since I expect to migrate xsnap to endo before too much longer.

@dckc dckc enabled auto-merge September 2, 2021 21:16
@dckc dckc disabled auto-merge September 2, 2021 21:16
@dckc dckc enabled auto-merge (squash) September 2, 2021 21:17
@dckc dckc force-pushed the 2776-xsnap-ses-deterministic branch from 825c15b to cbca7d4 Compare September 2, 2021 21:17
@dckc dckc merged commit 95c5f01 into master Sep 2, 2021
@dckc dckc deleted the 2776-xsnap-ses-deterministic branch September 2, 2021 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xsnap + SES boot not deterministic
2 participants