Properly handle remotables vs presences in weak collections #3142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FUDCo
force-pushed
the
3115-weak-collection-enhancements
branch
from
4af2ae4
to
69c5c61
Compare
warner
reviewed
May 20, 2021
FUDCo
force-pushed
the
3115-weak-collection-enhancements
branch
from
69c5c61
to
d033227
Compare
FUDCo
force-pushed
the
3115-weak-collection-enhancements
branch
2 times, most recently
from
27ff1b0
to
41ffa2c
Compare
warner
reviewed
May 21, 2021
| @@ -253,8 +263,8 @@ export function makeVirtualObjectManager( | |||
| function virtualObjectKey(key) { | |||
| const vobjID = valToSlot.get(key); | |||
| if (vobjID) { | |||
| const { type, virtual } = parseVatSlot(vobjID); | |||
| if (type === 'object' && virtual) { | |||
| const { type, virtual, allocatedByVat } = parseVatSlot(vobjID); | |||
There was a problem hiding this comment.
This looks great for addressing #3115: keys which are Presences or Representatives use their vref as the index, keys which are Remotables (or any non-vref-bearing object) use the Object identity.
warner
reviewed
May 21, 2021
warner
reviewed
May 21, 2021
warner
reviewed
May 21, 2021
| let memorableExportRemotable; | ||
| let memorableExportVirtualObject; | ||
| let memorableExportPromise; | ||
| let forgetableExportRemotable; |
There was a problem hiding this comment.
To be even more explicit, you could put the forgetable ones inside the scope of prepareWeakMap, so they wouldn't even be in scope during probeWeakMap. Nulling them out is fine belt-and-suspenders. (I can imagine a JS engine following a different code path for "value fell out of scope" vs "value was explicitly overwritten", with conceivably different GC timing).
warner
requested changes
May 21, 2021
FUDCo
force-pushed
the
3115-weak-collection-enhancements
branch
from
41ffa2c
to
e4a32a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3115