chore: update 'cosmic-swingset' package to use AVA #1602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warner
force-pushed
the
1568-cosmic-swingset
branch
from
019ed34
to
1a54efd
Compare
Per @michaelfig, test-scenario3-setup.js is not necessary, because test-home exercises the same thing. By removing it, we can run all the test *files* in parallel (removing the `ava --serial` argument). We still run the test *functions* within `test-home.js` serially, because they all interact with the same running system. But by removing `--serial`, we will be able to run the top-level `yarn test` in parallel across all packages.
michaelfig
approved these changes
Aug 24, 2020
This was referenced Jul 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to make the tests run with
--serial, because (I think) test-home.js and test-make.js both try to use the same directory. I changedtest-home.jsto run all the individual tests serially, with asetupat the start andteardownat the end, to match the previous behavior.refs #1568