fix: use REMOTE_STYLE rather than 'presence' to prepare #1577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelfig
approved these changes
Aug 30, 2020
|
The swingset tests were using |
erights
added a commit
that referenced
this pull request
Aug 31, 2020
erights
added a commit
that referenced
this pull request
Aug 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
passStyleOf(remotable)is'presence', which mixes abstraction levels. It should be'remote'. To prepare to make this change, @michaelfig introduced theREMOTE_STYLEglobal constant whose current value is'presence'. However, we still had the literal'presence'string scattered throughout our code. This replaces all those with theREMOTE_STYLEconstant until we have made the transition.I verified that, in the PR, if we set the constant to
'remote'CI still passes. However, we do not intend to actually take this step at this time. This PR is just to prepare.