Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add Zoe methods for getting assured invitation values #1474

Merged
merged 1 commit into from
Aug 15, 2020

Conversation

Chris-Hibbert
Copy link
Contributor

closes #1456

Copy link
Contributor

@katelynsills katelynsills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! I think Dean was saying that he wanted a record returned, but honestly, the individual calls are so much cleaner, I think I like this version better.

* @property {Installation} installation
* @property {Instance} instance
* @property {InvitationHandle} handle
* @property {string} description
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're going to need to capture the custom properties by doing something like this:

 * @typedef {StandardInvitationDetails & Record<string, any>} InvitationDetails

Where StandardInvitationDetails is what you have now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Zoe package: Zoe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants