Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VatTP-over-IBC #1338

Merged
merged 5 commits into from
Aug 2, 2020
Merged

Add VatTP-over-IBC #1338

merged 5 commits into from
Aug 2, 2020

Conversation

warner
Copy link
Member

@warner warner commented Jul 28, 2020

This implements the demo described in #259.

@michaelfig michaelfig changed the title add vattp-over-IBC Add VatTP-over-IBC Aug 1, 2020
@michaelfig michaelfig marked this pull request as ready for review August 1, 2020 00:54
@michaelfig michaelfig added cosmic-swingset package: cosmic-swingset SwingSet package: SwingSet labels Aug 1, 2020
Copy link
Contributor

@FUDCo FUDCo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okfinewhatever

@@ -164,7 +164,7 @@ func handleMsgProvision(ctx sdk.Context, keeper Keeper, msg MsgProvision) (*sdk.
}

// Create the account, if it doesn't already exist.
egress := types.NewEgress(msg.Nickname, msg.Address)
egress := types.NewEgress(msg.Nickname, msg.Address, msg.PowerFlags)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I correct in thinking that the author of the ProvisionOne transaction can choose whatever PowerFlags they want (i.e. the single "give them everything" one we added, which only actually gives them the ability to set up network connections), but these transactions will only be accepted in messages signed by keys associated with accounts that hold a provisionpass token? And that this PR doesn't show the provisionpass check because that was already present in the previous revisions?

Copy link
Member

@michaelfig michaelfig Aug 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no "give them everything" flag when running on a real chain. That only exists when running on the fake chain. You are correct that this is checked against the provisionpass, which was already present.

@michaelfig michaelfig merged commit d582c79 into master Aug 2, 2020
@michaelfig michaelfig deleted the 259-vattp-ibc branch August 2, 2020 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cosmic-swingset package: cosmic-swingset SwingSet package: SwingSet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants