test(a3p): migrate wallet and vaults related tests from a3p-proposals
to the z:acceptance
#10123
+492
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: Agoric/BytePitchPartnerEng#5
closes: Agoric/BytePitchPartnerEng#7
refs: #10049
Description
This PR is part of an ongoing effort to migrate some of the selected test cases from
a3p-proposals
to thez:acceptance
test phase. More specifically:Note: At the issues mentioned under "closes", we list the specific proposals of the selected test cases.
Security Considerations
n/a
Scaling Considerations
n/a
Documentation Considerations
One commit included in this PR fixes a small typo on
a3p-integration/proposals/README.md
Testing Considerations
The new test files included in this PR are invoked through
test.sh
, so no changes to the current testing workflow are necessary.However, as pointed out by @dckc in this comment, using
waitForBlock()
can lead to unexpected behavior. To address this, we plan to update thez:acceptance
tests to mitigate this issue.As a solution, we propose extending the
@agoric/synthetic-chain
package to export a method like makeRetryUntilCondition or a similar function. This would provide a more reliable alternative towaitForBlock()
.Additionally, there is already an test-vaults.mts file that test operations related to changes on auctions parameters.
To avoid confusion with
vaults.test
due to the similarity in names, I propose renaming this file toauction.test
and expanding its scope to cover all auction-related tests.Upgrade Considerations
n/a