Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kernel reentrancy on fake-chain #763

Closed
michaelfig opened this issue Mar 24, 2020 · 0 comments · Fixed by #764
Closed

Kernel reentrancy on fake-chain #763

michaelfig opened this issue Mar 24, 2020 · 0 comments · Fixed by #764
Assignees
Labels
cosmic-swingset package: cosmic-swingset

Comments

@michaelfig
Copy link
Member

It appears that when the fake chain is run with no delay, we have newly-introduced contention between the simulation timeout and the deliver. We should eliminate this with a simulateBlock input queue.

SwingSet: kernel: We're currently already running at Error <Object <[Object: null prototype] {}>>: here
    at processQueueMessage (/SwingSet/kernel/packages/SwingSet/src/kernel/kernel.js:452:31)
    at Object.run (/SwingSet/kernel/packages/SwingSet/src/kernel/kernel.js:846:15)
    at async deliverInbound (/Users/michael/agoric/agoric-sdk/packages/cosmic-swingset/lib/launch-chain.js:107:5)
fake-chain: error fake processing Error <Object <[Object: null prototype] {}>>: Kernel reentrancy is forbidden
    at processQueueMessage (/SwingSet/kernel/packages/SwingSet/src/kernel/kernel.js:448:15)
    at Object.run (/SwingSet/kernel/packages/SwingSet/src/kernel/kernel.js:846:15)
    at Object.run (/Users/michael/agoric/agoric-sdk/packages/SwingSet/src/controller.js:350:21)
    at deliverInbound (/Users/michael/agoric/agoric-sdk/packages/cosmic-swingset/lib/launch-chain.js:107:22)
    at kernelPerformAction (/Users/michael/agoric/agoric-sdk/packages/cosmic-swingset/lib/block-manager.js:31:13)
    at blockManager (/Users/michael/agoric/agoric-sdk/packages/cosmic-swingset/lib/block-manager.js:95:13)
    at simulateBlock (/Users/michael/agoric/agoric-sdk/packages/cosmic-swingset/lib/ag-solo/fake-chain.js:74:15)
    at async Object.deliver [as deliverator] (/Users/michael/agoric/agoric-sdk/packages/cosmic-swingset/lib/ag-solo/fake-chain.js:109:7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cosmic-swingset package: cosmic-swingset
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant