Await safety uncertain in SwingSet/src/controller/initializeSwingset.js

[erights]

agoric-sdk/packages/SwingSet/src/controller/initializeSwingset.js

Line 333 in a1dedea

kernelBundles = await buildVatAndDeviceBundles(),

The triage at #6219 currently classifies this as

// TODO FIXME This code should be refactored to make this
// await checkably safe, or to remove it, or to record here
// why it is actually safe.
//
// As the default value of a destructuring, this `await` is bizarrely
// conditional. It'll happen if `kernelBundles` is either absent or
// undefined in `initializationOptions`, in which case we'll take a turn
// boundary here. Otherwise, we'll continue into the subsequent code
// synchronously. I could make this safe by introducing an extra turn
// boundary, but for this code I'm scared to do that without understanding
// the code better first.

Git blame shows @warner @FUDCo and @dckc as the ones who should probably investigate this, so I'm assigning to them. Feel free to reassign as appropriate of course.

[dckc]

I'm inclined to leave this to others. Let me know if you'd rather I stay involved.

[erights]

If @warner or @FUDCo pick this up, that's certainly adequate. Feel free to remove yourself from the assignees.