install-on-chain.js files aren't being linted #3672
Labels
Comments
katelynsills
added a commit
that referenced
this issue
Aug 13, 2021
See #3672 for the issue to fix the root problem
katelynsills
added a commit
that referenced
this issue
Aug 13, 2021
See #3672 for the issue to fix the root problem
katelynsills
added a commit
that referenced
this issue
Aug 13, 2021
* BREAKING CHANGE: make the run mint within Zoe, and give only the treasury the ability to create a ZCFMint with it * chore: change 'makeZoe' to 'makeZoeKit' * chore: add "shutdownZoeVat" argument to Zoe, and pass it to `makeIssuerKit` for invitation issuerKit and fee issuerKit * chore: manually lint-fix install-on-chain.js See #3672 for the issue to fix the root problem
katelynsills
added a commit
that referenced
this issue
Aug 14, 2021
* BREAKING CHANGE: make the run mint within Zoe, and give only the treasury the ability to create a ZCFMint with it * chore: change 'makeZoe' to 'makeZoeKit' * chore: add "shutdownZoeVat" argument to Zoe, and pass it to `makeIssuerKit` for invitation issuerKit and fee issuerKit * chore: manually lint-fix install-on-chain.js See #3672 for the issue to fix the root problem
katelynsills
added a commit
that referenced
this issue
Aug 14, 2021
* BREAKING CHANGE: make the run mint within Zoe, and give only the treasury the ability to create a ZCFMint with it * chore: change 'makeZoe' to 'makeZoeKit' * chore: add "shutdownZoeVat" argument to Zoe, and pass it to `makeIssuerKit` for invitation issuerKit and fee issuerKit * chore: manually lint-fix install-on-chain.js See #3672 for the issue to fix the root problem
michaelfig
pushed a commit
that referenced
this issue
Aug 16, 2021
* BREAKING CHANGE: make the run mint within Zoe, and give only the treasury the ability to create a ZCFMint with it * chore: change 'makeZoe' to 'makeZoeKit' * chore: add "shutdownZoeVat" argument to Zoe, and pass it to `makeIssuerKit` for invitation issuerKit and fee issuerKit * chore: manually lint-fix install-on-chain.js See #3672 for the issue to fix the root problem
michaelfig
pushed a commit
that referenced
this issue
Aug 17, 2021
* BREAKING CHANGE: make the run mint within Zoe, and give only the treasury the ability to create a ZCFMint with it * chore: change 'makeZoe' to 'makeZoeKit' * chore: add "shutdownZoeVat" argument to Zoe, and pass it to `makeIssuerKit` for invitation issuerKit and fee issuerKit * chore: manually lint-fix install-on-chain.js See #3672 for the issue to fix the root problem
dckc
added
cosmic-swingset
|
@dckc When I first started working on our ZH board, I marked this as being for the Mainnet 1 release because it was already in the Review/QA pipeline. This seems like it is an open question, not really In Review or In QA. Should this be moved back to the MN-1 backlog, or taken out of the Mainnet 1 release altogether. |
|
Out of mn-1 Though it is likely to be addressed with #4165 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Our eslint settings ignore files within
bundles/**So this means that these two files should probably be moved out of "bundles":
packages/pegasus/bundles/install-on-chain.js
packages/treasury/bundles/install-on-chain.js
Originally posted by @katelynsills in #3647 (comment)
The text was updated successfully, but these errors were encountered: