Merge pull request #6582 from Agoric/ta/this-type

types for `this` in far classes
Agoric · Nov 18, 2022 · e5ed233 · e5ed233
2 parents a5437cf + 91fdd77
commit e5ed233
Show file tree

Hide file tree

Showing 43 changed files with 108 additions and 63 deletions.
diff --git a/packages/ERTP/jsconfig.json b/packages/ERTP/jsconfig.json
@@ -6,6 +6,7 @@
     "noEmit": true,
     "downlevelIteration": true,
     "strictNullChecks": true,
+    "noImplicitThis": true,
     "moduleResolution": "node",
     "types": [
       "node"

diff --git a/packages/SwingSet/jsconfig.json b/packages/SwingSet/jsconfig.json
@@ -6,6 +6,7 @@
     "checkJs": true,
     "noEmit": true,
     "strictNullChecks": true,
+    "noImplicitThis": true,
     "moduleResolution": "node",
   },
   "include": [

diff --git a/packages/SwingSet/src/lib-nodejs/worker-protocol.js b/packages/SwingSet/src/lib-nodejs/worker-protocol.js
@@ -7,6 +7,7 @@ import { Transform } from 'stream';
 export function arrayEncoderStream() {
   /**
    *
+   * @this {{ push: (b: Buffer) => void }}
    * @param {*} object
    * @param {BufferEncoding} encoding
    * @param {*} callback
@@ -30,6 +31,7 @@ export function arrayEncoderStream() {
 export function arrayDecoderStream() {
   /**
    *
+   * @this {{ push: (b: Buffer) => void }}
    * @param {Buffer} buf
    * @param {BufferEncoding} encoding
    * @param {*} callback

diff --git a/packages/SwingSet/src/lib/netstring.js b/packages/SwingSet/src/lib/netstring.js
@@ -22,6 +22,7 @@ export function encode(data) {
 export function netstringEncoderStream() {
   /**
    *
+   * @this {{ push: (b: Buffer) => void }}
    * @param {Buffer} chunk
    * @param {BufferEncoding} encoding
    * @param {*} callback
@@ -86,6 +87,7 @@ export function netstringDecoderStream(optMaxChunkSize) {
   let buffered = Buffer.from('');
   /**
    *
+   * @this {{ push: (b: Buffer) => void }}
    * @param {Buffer} chunk
    * @param {BufferEncoding} encoding
    * @param {*} callback

diff --git a/packages/access-token/jsconfig.json b/packages/access-token/jsconfig.json
@@ -12,6 +12,7 @@
 */
     "downlevelIteration": true,
     "strictNullChecks": true,
+    "noImplicitThis": true,
     "moduleResolution": "node",
   },
   "include": [

diff --git a/packages/agoric-cli/jsconfig.json b/packages/agoric-cli/jsconfig.json
@@ -13,6 +13,7 @@
 */
     "downlevelIteration": true,
     "strictNullChecks": true,
+    "noImplicitThis": true,
     "moduleResolution": "node",
   },
   "include": [

diff --git a/packages/agoric-cli/src/commands/oracle.js b/packages/agoric-cli/src/commands/oracle.js
@@ -69,6 +69,7 @@ export const makeOracleCommand = async logger => {
     )
     .option('--offerId [number]', 'Offer id', Number, Date.now())
     .action(async function () {
+      // @ts-expect-error this implicit any
       const opts = this.opts();
 
       const instance = lookupPriceAggregatorInstance(opts.pair);
@@ -104,6 +105,7 @@ export const makeOracleCommand = async logger => {
     )
     .requiredOption('--price [number]', 'price (format TODO)', String)
     .action(async function () {
+      // @ts-expect-error this implicit any
       const opts = this.opts();
 
       /** @type {import('../lib/psm.js').OfferSpec} */
@@ -136,6 +138,7 @@ export const makeOracleCommand = async logger => {
       ['ATOM', 'USD'],
     )
     .action(async function () {
+      // @ts-expect-error this implicit any
       const { pair } = this.opts();
 
       const capDataStr = await vstorage.readLatest(

diff --git a/packages/agoric-cli/src/commands/perf.js b/packages/agoric-cli/src/commands/perf.js
@@ -45,6 +45,7 @@ export const makePerfCommand = async logger => {
     )
     .option('--home [string]', 'directory for config and data')
     .action(async function () {
+      // @ts-expect-error this implicit any
       const opts = this.opts();
       logger.warn({ opts });
       const payloadStr = await fs.readFileSync(opts.executeOffer).toString();

diff --git a/packages/agoric-cli/src/commands/psm.js b/packages/agoric-cli/src/commands/psm.js
@@ -126,6 +126,7 @@ export const makePsmCommand = async logger => {
       ['IST', 'AUSD'],
     )
     .action(async function () {
+      // @ts-expect-error this implicit any
       const { pair } = this.opts();
       const { governance } = await getGovernanceState(pair);
       console.log('psm governance params', Object.keys(governance));
@@ -159,6 +160,7 @@ export const makePsmCommand = async logger => {
     .option('--feePct [%]', 'Gas fee percentage', Number)
     .option('--offerId [number]', 'Offer id', Number, Date.now())
     .action(async function () {
+      // @ts-expect-error this implicit any
       const opts = this.opts();
       console.warn('running with options', opts);
       const instance = await lookupPsmInstance(opts.pair);
@@ -172,6 +174,7 @@ export const makePsmCommand = async logger => {
     .description('join the economic committee')
     .option('--offerId [number]', 'Offer id', Number, Date.now())
     .action(async function () {
+      // @ts-expect-error this implicit any
       const opts = this.opts();
 
       const { economicCommittee } = agoricNames.instance;
@@ -202,6 +205,7 @@ export const makePsmCommand = async logger => {
     .description('prepare an offer to accept the charter invitation')
     .option('--offerId [number]', 'Offer id', Number, Date.now())
     .action(async function () {
+      // @ts-expect-error this implicit any
       const opts = this.opts();
 
       const { psmCharter } = agoricNames.instance;
@@ -255,6 +259,7 @@ export const makePsmCommand = async logger => {
       1,
     )
     .action(async function () {
+      // @ts-expect-error this implicit any
       const opts = this.opts();
 
       const psmInstance = lookupPsmInstance(opts.pair);
@@ -312,6 +317,7 @@ export const makePsmCommand = async logger => {
       1,
     )
     .action(async function () {
+      // @ts-expect-error this implicit any
       const opts = this.opts();
 
       const psmInstance = lookupPsmInstance(opts.pair);
@@ -366,6 +372,7 @@ export const makePsmCommand = async logger => {
       Number,
     )
     .action(async function () {
+      // @ts-expect-error this implicit any
       const opts = this.opts();
 
       const questionHandleCapDataStr = await vstorage.readLatest(

diff --git a/packages/agoric-cli/src/commands/wallet.js b/packages/agoric-cli/src/commands/wallet.js
@@ -53,6 +53,7 @@ export const makeWalletCommand = async () => {
         spend,
         home,
         keyringBackend: backend,
+        // @ts-expect-error this implicit any
       } = this.opts();
       const tx = `provision-one ${nickname} ${account} SMART_WALLET`;
       if (spend) {
@@ -102,6 +103,7 @@ export const makeWalletCommand = async () => {
         offer,
         home,
         keyringBackend: backend,
+        // @ts-expect-error this implicit any
       } = this.opts();
 
       execSwingsetTransaction(
@@ -131,6 +133,7 @@ export const makeWalletCommand = async () => {
       normalizeAddress,
     )
     .action(async function () {
+      // @ts-expect-error this implicit any
       const opts = this.opts();
 
       const { agoricNames, fromBoard, vstorage } = await makeRpcUtils({
@@ -176,6 +179,7 @@ export const makeWalletCommand = async () => {
       normalizeAddress,
     )
     .action(async function () {
+      // @ts-expect-error this implicit any
       const { from } = this.opts();
       const spec = `:published.wallet.${from}`;
 

diff --git a/packages/assert/jsconfig.json b/packages/assert/jsconfig.json
@@ -3,16 +3,16 @@
   "compilerOptions": {
     "target": "esnext",
     "module": "esnext",
-
     "noEmit": true,
-/*
+    /*
     // The following flags are for creating .d.ts files:
     "noEmit": false,
     "declaration": true,
     "emitDeclarationOnly": true,
 */
     "downlevelIteration": true,
     "strictNullChecks": true,
+    "noImplicitThis": true,
     "moduleResolution": "node",
   },
   "include": [

diff --git a/packages/cache/jsconfig.json b/packages/cache/jsconfig.json
@@ -7,6 +7,7 @@
     "noEmit": true,
     "downlevelIteration": true,
     "strictNullChecks": true,
+    "noImplicitThis": true,
     "moduleResolution": "node",
   },
   "include": [

diff --git a/packages/casting/jsconfig.json b/packages/casting/jsconfig.json
@@ -7,6 +7,7 @@
     "noEmit": true,
     "downlevelIteration": true,
     "strictNullChecks": true,
+    "noImplicitThis": true,
     "moduleResolution": "node",
   },
   "include": [

diff --git a/packages/cosmic-proto/tsconfig.json b/packages/cosmic-proto/tsconfig.json
@@ -7,6 +7,7 @@
     "allowSyntheticDefaultImports": true,
     "downlevelIteration": true,
     "strictNullChecks": true,
+    "noImplicitThis": true,
     "moduleResolution": "node",
     "outDir": "dist"
   },

diff --git a/packages/cosmic-swingset/jsconfig.json b/packages/cosmic-swingset/jsconfig.json
@@ -12,6 +12,7 @@
 */
     "downlevelIteration": true,
     "strictNullChecks": true,
+    "noImplicitThis": true,
     "moduleResolution": "node",
   },
   "include": [

diff --git a/packages/deploy-script-support/jsconfig.json b/packages/deploy-script-support/jsconfig.json
@@ -7,6 +7,7 @@
     "noEmit": true,
     "downlevelIteration": true,
     "strictNullChecks": true,
+    "noImplicitThis": true,
     "moduleResolution": "node",
   },
   "include": [

diff --git a/packages/deployment/jsconfig.json b/packages/deployment/jsconfig.json
@@ -12,6 +12,7 @@
 */
     "downlevelIteration": true,
     "strictNullChecks": true,
+    "noImplicitThis": true,
     "moduleResolution": "node",
   },
   "include": [

diff --git a/packages/governance/jsconfig.json b/packages/governance/jsconfig.json
@@ -6,6 +6,7 @@
     "noEmit": true,
     "downlevelIteration": true,
     "strictNullChecks": true,
+    "noImplicitThis": true,
     "moduleResolution": "node",
   },
   "include": [

diff --git a/packages/inter-protocol/jsconfig.json b/packages/inter-protocol/jsconfig.json
@@ -7,6 +7,7 @@
     "noEmit": true,
     "downlevelIteration": true,
     "strictNullChecks": true,
+    "noImplicitThis": true,
     "moduleResolution": "node",
   },
   "include": [

diff --git a/packages/internal/jsconfig.json b/packages/internal/jsconfig.json
@@ -7,6 +7,7 @@
     "downlevelIteration": true,
     "noImplicitAny": true,
     "strictNullChecks": true,
+    "noImplicitThis": true,
     "moduleResolution": "node",
     "types": [
       "node"

diff --git a/packages/notifier/jsconfig.json b/packages/notifier/jsconfig.json
@@ -7,6 +7,7 @@
     "noEmit": true,
     "downlevelIteration": true,
     "strictNullChecks": true,
+    "noImplicitThis": true,
     "moduleResolution": "node",
   },
   "include": [

diff --git a/packages/pegasus/jsconfig.json b/packages/pegasus/jsconfig.json
@@ -3,16 +3,16 @@
   "compilerOptions": {
     "target": "esnext",
     "module": "esnext",
-
     "noEmit": true,
-/*
+    /*
     // The following flags are for creating .d.ts files:
     "noEmit": false,
     "declaration": true,
     "emitDeclarationOnly": true,
 */
     "downlevelIteration": true,
     "strictNullChecks": true,
+    "noImplicitThis": true,
     "moduleResolution": "node",
   },
   "include": [

diff --git a/packages/smart-wallet/jsconfig.json b/packages/smart-wallet/jsconfig.json
@@ -6,6 +6,7 @@
     "noEmit": true,
     "downlevelIteration": true,
     "strictNullChecks": true,
+    "noImplicitThis": true,
     "moduleResolution": "node",
   },
   "include": [