fix(newSwap): move guard out of conditional; tests pass

Agoric · May 4, 2021 · dc67e67 · dc67e67
1 parent 8970dca
commit dc67e67
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/packages/zoe/src/contracts/newSwap/swap.js b/packages/zoe/src/contracts/newSwap/swap.js
@@ -174,6 +174,11 @@ export const makeMakeSwapInvitation = (
       centralAmount,
     } = getPriceGivenRequiredOutput(brandIn, amountOut);
 
+    if (!amountMath.isGTE(offeredAmountIn, amountIn)) {
+      const reason = `offeredAmountIn ${offeredAmountIn} is insufficient to buy amountOut ${amountOut}`;
+      throw seat.fail(Error(reason));
+    }
+
     const stagings = [];
     stagings.push(stageProtocolSeatFee(protocolFee));
     stagings.push(
@@ -186,10 +191,6 @@ export const makeMakeSwapInvitation = (
     // central to secondary, secondary to central, or secondary to secondary
     const pools = [];
     if (isCentral(brandOut) && isSecondary(brandIn)) {
-      if (!amountMath.isGTE(offeredAmountIn, amountIn)) {
-        const reason = `offeredAmountIn ${offeredAmountIn} is insufficient to buy amountOut ${amountOut}`;
-        throw seat.fail(Error(reason));
-      }
       stagings.push(
         poolStagingToCentral(amountIn, improvedAmountOut, protocolFee),
       );