chore: Resolve Array.forEach lint warnings (#9688)

Ref #9632

## Description
Replaced `Array.forEach();` calls with `for ( x of y ) { };` loops.

### Security Considerations
Assume that Array.forEach() calls are equivalent to `for ( x of y ) { };` in all cases.

### Scaling Considerations
No significant difference expected.

### Documentation Considerations
N/A

### Testing Considerations
No new tests required. Local tests passed, including lint (specific to this PR).

### Upgrade Considerations
The change preserves the behavior, thus there are no upgrade concerns.

packages/cosmic-swingset/src/kernel-stats.js

@@ -316,13 +316,13 @@ export function exportKernelStats({
     }
     kernelStatsLast = now;
     kernelStatsCache = controller.getStats();
-    Object.keys(kernelStatsCache).forEach(key => {
+    for (const key of Object.keys(kernelStatsCache)) {
       warnUnexpectedKernelStat(key);
-    });
+    }
     return kernelStatsCache;
   };
 
-  KERNEL_STATS_SUM_METRICS.forEach(({ key, name, sub, ...options }) => {
+  for (const { key, name, sub, ...options } of KERNEL_STATS_SUM_METRICS) {
     expectedKernelStats.add(key);
     let counter = kernelStatsCounters.get(name);
     if (!counter) {
@@ -337,9 +337,9 @@ export function exportKernelStats({
       observableResult.observe(getKernelStats()[key], reportedAttributes);
     });
     kernelStatsMetrics.add(key);
-  });
+  }
 
-  KERNEL_STATS_UPDOWN_METRICS.forEach(({ key, name, sub, ...options }) => {
+  for (const { key, name, sub, ...options } of KERNEL_STATS_UPDOWN_METRICS) {
     expectedKernelStats.add(key);
     expectedKernelStats.add(`${key}Up`);
     expectedKernelStats.add(`${key}Down`);
@@ -357,7 +357,7 @@ export function exportKernelStats({
       observableResult.observe(getKernelStats()[key], reportedAttributes);
     });
     kernelStatsMetrics.add(key);
-  });
+  }
 
   if (inboundQueueMetrics) {
     // These are not kernelStatsMetrics, they're outside the kernel.
@@ -425,13 +425,13 @@ export function exportKernelStats({
 
   function checkKernelStats(stats) {
     const notYetFoundKernelStats = new Set(kernelStatsMetrics.keys());
-    Object.keys(stats).forEach(key => {
+    for (const key of Object.keys(stats)) {
       notYetFoundKernelStats.delete(key);
       warnUnexpectedKernelStat(key);
-    });
-    notYetFoundKernelStats.forEach(key => {
+    }
+    for (const key of notYetFoundKernelStats) {
       log.warn(`Expected SwingSet kernel statistic`, key, `not found`);
-    });
+    }
   }
 
   // We check everything on initialization.  Other checks happen when scraping.

packages/cosmic-swingset/test/export-storage.test.js

@@ -47,9 +47,12 @@ const makeBatchChainStorage = published => {
         const [path] = args;
         return entries(path).map(([key]) => key);
       }
-      case 'setWithoutNotify':
-        args.forEach(([path]) => deleted.push(path));
+      case 'setWithoutNotify': {
+        for (const [path] of args) {
+          deleted.push(path);
+        }
         return;
+      }
       default:
         throw Error(`not impl: ${method}`);
     }

packages/internal/src/utils.js

@@ -227,7 +227,9 @@ export const synchronizedTee = (sourceStream, readerCount) => {
         doneResult = { done: true, value: undefined };
       },
     );
-    resolvers.forEach(resolve => resolve(result));
+    for (const resolve of resolvers) {
+      resolve(result);
+    }
     return pullNext();
   };
 

packages/notifier/test/publish-kit.test.js

@@ -82,6 +82,8 @@ const assertCells = (t, label, cells, publishCount, expected, options = {}) => {
     }
   } else {
     const { tail: _tail, ...props } = firstCell;
+    // We need an element and an index here, which for..of does not give us in one go
+    // eslint-disable-next-line github/array-foreach
     cells.slice(1).forEach((cell, i) => {
       t.like(cell, props, `${label} cell ${i + 1} must match cell 0`);
     });

packages/solo/src/chain-cosmos-sdk.js

@@ -442,6 +442,7 @@ export async function connectToChain(
 
           // Find only the latest value in the events.
           let storageValue;
+          // eslint-disable-next-line github/array-foreach
           paths.forEach((key, i) => {
             if (key === storagePath) {
               storageValue = values[i];

packages/solo/src/outbound.js

@@ -33,7 +33,7 @@ export function deliver(mbs) {
     }
     const t = knownTargets.get(target);
     const newMessages = [];
-    data[target].outbox.forEach(m => {
+    for (const m of data[target].outbox) {
       const [msgnum, body] = m;
       if (msgnum > t.highestSent) {
         log.debug(
@@ -44,7 +44,7 @@ export function deliver(mbs) {
         );
         newMessages.push(m);
       }
-    });
+    }
     newMessages.sort((a, b) => a[0] - b[0]);
     // console.debug(` ${newMessages.length} new messages`);
     const acknum = data[target].inboundAck;

packages/solo/src/set-fake-chain.js

@@ -29,16 +29,18 @@ export default function setFakeChain(basedir, GCI, fakeDelay) {
     }
   };
 
-  JSON.parse(fs.readFileSync(fn)).forEach(add);
+  for (const conn of JSON.parse(fs.readFileSync(fn))) {
+    add(conn);
+  }
   const newconn = {
     type: 'fake-chain',
     GCI,
     fakeDelay,
   };
   add(newconn);
   const connections = [];
-  Object.entries(connsByType).forEach(([_type, conns]) =>
-    connections.push(...conns),
-  );
+  for (const conns of Object.values(connsByType)) {
+    connections.push(...conns);
+  }
   fs.writeFileSync(fn, `${JSON.stringify(connections, undefined, 2)}\n`);
 }

packages/solo/src/set-gci-ingress.js

@@ -58,7 +58,9 @@ export default function setGCIIngress(basedir, GCI, rpcAddresses, chainID) {
     }
   };
 
-  JSON.parse(fs.readFileSync(fn)).forEach(add);
+  for (const conn of JSON.parse(fs.readFileSync(fn))) {
+    add(conn);
+  }
   const newconn = {
     type: 'chain-cosmos-sdk',
     chainID,
@@ -68,9 +70,8 @@ export default function setGCIIngress(basedir, GCI, rpcAddresses, chainID) {
   };
   add(newconn);
   const connections = [];
-  // eslint-disable-next-line no-unused-vars
-  Object.entries(connsByType).forEach(([type, conns]) =>
-    connections.push(...conns),
-  );
+  for (const conns of Object.values(connsByType)) {
+    connections.push(...conns);
+  }
   fs.writeFileSync(fn, `${JSON.stringify(connections, undefined, 2)}\n`);
 }

packages/solo/src/web.js

@@ -306,14 +306,14 @@ export async function makeHTTPListener(
   server.listen(port, host, () => log.info('Listening on', `${host}:${port}`));
 
   const pingInterval = setInterval(function ping() {
-    wss.clients.forEach(ws => {
+    for (const ws of wss.clients) {
       if (!ws.isAlive) {
         ws.terminate();
         return;
       }
       ws.isAlive = false;
       ws.ping(() => {});
-    });
+    }
   }, 30000);
 
   wss.on('close', () => clearInterval(pingInterval));

packages/vats/test/demoAMM.test.js

@@ -82,7 +82,7 @@ test('poolRates: spot check WETH', t => {
     interestRate: '0.025',
     mintFee: '0.0001',
   };
-  Object.entries(expected).forEach(([prop, val]) =>
-    t.is(showRatio(rates[prop]), val),
-  );
+  for (const [prop, val] of Object.entries(expected)) {
+    t.is(showRatio(rates[prop]), val);
+  }
 });

packages/wallet/api/src/pubsub.js

@@ -11,9 +11,9 @@ export default function makePubsub(E) {
     },
     publish(m) {
       lastPublished = m;
-      subscribers.forEach(s => {
+      for (const s of subscribers) {
         E(s).notify(m);
-      });
+      }
     },
   });
 }

packages/wallet/api/src/wallet.js

@@ -58,7 +58,7 @@ export function buildRootObject(vatPowers) {
 
   const pushOfferSubscriptions = (channelHandle, offers) => {
     const subs = offerSubscriptions.get(channelHandle);
-    (subs || []).forEach(({ origin, status }) => {
+    for (const { origin, status } of subs || []) {
       // Filter by optional status and origin.
       const result = harden(
         offers.filter(
@@ -75,7 +75,7 @@ export function buildRootObject(vatPowers) {
         },
         [channelHandle],
       );
-    });
+    }
   };
 
   const subscribeToOffers = (channelHandle, { origin, status = null }) => {

packages/xsnap/src/avaXS.js

@@ -384,7 +384,9 @@ export async function main(
 
     stats.total += results.total;
     stats.pass += results.pass;
-    results.fail.forEach(info => stats.fail.push(info));
+    for (const info of results.fail) {
+      stats.fail.push(info);
+    }
   }
 
   console.log(stats.pass, 'tests passed');

packages/zoe/src/cleanProposal.js

@@ -47,7 +47,9 @@ export const cleanKeywords = uncleanKeywordRecord => {
 
   // Assert all names are ascii identifiers starting with
   // an upper case letter.
-  keywords.forEach(assertKeywordName);
+  for (const keyword of keywords) {
+    assertKeywordName(keyword);
+  }
 
   return /** @type {string[]} */ (keywords);
 };

packages/zoe/src/contractFacet/rightsConservation.js

@@ -18,15 +18,15 @@ import '../internal-types.js';
 const sumByBrand = amounts => {
   /** @type {MapStore<Brand, Amount>} */
   const sumsByBrand = makeScalarMapStore('brand');
-  amounts.forEach(amount => {
+  for (const amount of amounts) {
     const { brand } = amount;
     if (!sumsByBrand.has(brand)) {
       sumsByBrand.init(brand, amount);
     } else {
       const sumSoFar = sumsByBrand.get(brand);
       sumsByBrand.set(brand, AmountMath.add(sumSoFar, amount));
     }
-  });
+  }
   return sumsByBrand;
 };
 
@@ -76,11 +76,11 @@ const assertEqualPerBrand = (leftSumsByBrand, rightSumsByBrand) => {
     ...rightSumsByBrand.keys(),
   ]);
 
-  allBrands.forEach(brand => {
+  for (const brand of allBrands) {
     const { leftSum, rightSum } = getSums(brand);
     AmountMath.isEqual(leftSum, rightSum) ||
       Fail`rights were not conserved for brand ${brand} ${leftSum.value} != ${rightSum.value}`;
-  });
+  }
 };
 
 /**

packages/zoe/src/contractFacet/zcfSeat.js

@@ -412,8 +412,10 @@ export const createSeatManager = (
           }
         },
         reallocate(/** @type {ZCFSeat[]} */ ...seats) {
-          seats.forEach(assertActive);
-          seats.forEach(assertStagedAllocation);
+          for (const seat of seats) {
+            assertActive(seat);
+            assertStagedAllocation(seat);
+          }
 
           // Ensure that rights are conserved overall.
           const flattenAllocations = allocations =>
@@ -458,8 +460,9 @@ export const createSeatManager = (
             // for each of the seats) and inform Zoe of the
             // newAllocation.
 
-            seats.forEach(commitStagedAllocation);
-
+            for (const seat of seats) {
+              commitStagedAllocation(seat);
+            }
             const seatHandleAllocations = seats.map(seat => {
               const seatHandle = zcfSeatToSeatHandle.get(seat);
               return { seatHandle, allocation: seat.getCurrentAllocation() };

packages/zoe/src/contractSupport/zoeHelpers.js

@@ -136,11 +136,10 @@ export const assertProposalShape = (seat, expected) => {
   !Array.isArray(expected) || Fail`Expected must be an non-array object`;
   const assertValuesNull = e => {
     if (e !== undefined) {
-      Object.values(e).forEach(
-        value =>
-          value === null ||
-          Fail`The value of the expected record must be null but was ${value}`,
-      );
+      for (const value of Object.values(e)) {
+        value === null ||
+          Fail`The value of the expected record must be null but was ${value}`;
+      }
     }
   };
 

packages/zoe/src/contracts/auction/secondPriceLogic.js

@@ -20,7 +20,7 @@ export const calcWinnerAndClose = (zcf, sellSeat, bidSeats) => {
   let highestBidSeat = bidSeats[0];
   let activeBidsCount = 0n;
 
-  bidSeats.forEach(bidSeat => {
+  for (const bidSeat of bidSeats) {
     if (!bidSeat.hasExited()) {
       activeBidsCount += 1n;
       const bid = bidSeat.getAmountAllocated('Bid', bidBrand);
@@ -35,7 +35,7 @@ export const calcWinnerAndClose = (zcf, sellSeat, bidSeats) => {
         secondHighestBid = bid;
       }
     }
-  });
+  }
 
   if (activeBidsCount === 0n) {
     throw sellSeat.fail(Error(`Could not close auction. No bids were active`));
@@ -59,10 +59,10 @@ export const calcWinnerAndClose = (zcf, sellSeat, bidSeats) => {
   );
 
   sellSeat.exit();
-  bidSeats.forEach(bidSeat => {
+  for (const bidSeat of bidSeats) {
     if (!bidSeat.hasExited()) {
       bidSeat.exit();
     }
-  });
+  }
   zcf.shutdown('Auction closed.');
 };

packages/zoe/src/contracts/autoswap.js

@@ -64,7 +64,9 @@ const start = async zcf => {
   // In order to get all the brands, we must call zcf.getTerms() after
   // we create the liquidityIssuer
   const { brands } = zcf.getTerms();
-  Object.values(brands).forEach(brand => assertNatAssetKind(zcf, brand));
+  for (const brand of Object.values(brands)) {
+    assertNatAssetKind(zcf, brand);
+  }
   /** @type {Map<Brand,Keyword>} */
   const brandToKeyword = new Map(
     Object.entries(brands).map(([keyword, brand]) => [brand, keyword]),

packages/zoe/src/contracts/priceAggregator.js

@@ -146,11 +146,11 @@ const start = async (zcf, privateArgs) => {
     async wake(timestamp) {
       // Run all the queriers.
       const querierPs = [];
-      oracleRecords.forEach(({ querier }) => {
+      for (const { querier } of oracleRecords) {
         if (querier) {
           querierPs.push(querier(timestamp));
         }
-      });
+      }
       if (!querierPs.length) {
         // Only have push results, so publish them.
         // eslint-disable-next-line no-use-before-define

packages/zoe/src/issuerStorage.js

@@ -182,7 +182,9 @@ export const provideIssuerStorage = zcfBaggage => {
     if (!zcfBaggage.has(STORAGE_INSTANTIATED_KEY)) {
       zcfBaggage.init(STORAGE_INSTANTIATED_KEY, true);
       instantiated = true;
-      issuerRecords.forEach(storeIssuerRecord);
+      for (const record of issuerRecords) {
+        storeIssuerRecord(record);
+      }
     }
   };