fix(amm): Prevent creation of constant product AMM with non-fungible …

…central token
Agoric · Feb 8, 2022 · 4aeb93e · 4aeb93e
1 parent 2583ce0
commit 4aeb93e
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 1 deletion.
diff --git a/packages/run-protocol/src/vpool-xyk-amm/multipoolMarketMaker.js b/packages/run-protocol/src/vpool-xyk-amm/multipoolMarketMaker.js
@@ -7,6 +7,7 @@ import { AssetKind, makeIssuerKit } from '@agoric/ertp';
 import { CONTRACT_ELECTORATE, handleParamGovernance } from '@agoric/governance';
 
 import { assertIssuerKeywords } from '@agoric/zoe/src/contractSupport/index.js';
+import { E } from '@agoric/eventual-send';
 import { makeAddPool } from './pool.js';
 import { makeMakeAddLiquidityInvitation } from './addLiquidity.js';
 import { makeMakeRemoveLiquidityInvitation } from './removeLiquidity.js';
@@ -115,6 +116,13 @@ const start = async (zcf, privateArgs) => {
   } = /** @type { Terms & AMMTerms } */ (zcf.getTerms());
   assertIssuerKeywords(zcf, ['Central']);
   assert(centralBrand !== undefined, X`centralBrand must be present`);
+
+  const centralDisplayInfo = await E(centralBrand).getDisplayInfo();
+  assert(
+    centralDisplayInfo.assetKind === AssetKind.NAT,
+    X`Central must be of kind AssetKind.NAT`,
+  );
+
   const { initialPoserInvitation } = privateArgs;
 
   const paramManager = await makeParamManager(

diff --git a/packages/run-protocol/test/amm/vpool-xyk-amm/test-xyk-amm-swap.js b/packages/run-protocol/test/amm/vpool-xyk-amm/test-xyk-amm-swap.js
@@ -3,7 +3,7 @@
 // eslint-disable-next-line import/no-extraneous-dependencies
 import { test } from '@agoric/zoe/tools/prepare-test-env-ava.js';
 
-import { makeIssuerKit, AmountMath } from '@agoric/ertp';
+import { makeIssuerKit, AmountMath, AssetKind } from '@agoric/ertp';
 import { E } from '@agoric/eventual-send';
 
 import {
@@ -29,6 +29,21 @@ import { setupAmmServices } from './setup.js';
 const { quote: q } = assert;
 const { ceilDivide } = natSafeMath;
 
+test('amm with non-fungible central token', async t => {
+  // Set up central token
+  const centralR = makeIssuerKit('central', AssetKind.SET);
+  const electorateTerms = { committeeName: 'EnBancPanel', committeeSize: 3 };
+  const timer = buildManualTimer(console.log, 30n);
+
+  await t.throwsAsync(
+    () => setupAmmServices(electorateTerms, centralR, timer),
+    {
+      message: 'Central must be of kind AssetKind.NAT',
+    },
+    'test AssetKind.SET as central brand',
+  );
+});
+
 test('amm with valid offers', async t => {
   // Set up central token
   const centralR = makeIssuerKit('central');