fix(cosmic-swingset): Use 'junction' symlinks for directories

This is needed to symlink directories on Windows without requiring administrative privileges.
Agoric · Feb 22, 2021 · 1446df8 · 1446df8
1 parent 2721da7
commit 1446df8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/packages/cosmic-swingset/lib/ag-solo/init-basedir.js b/packages/cosmic-swingset/lib/ag-solo/init-basedir.js
@@ -86,7 +86,7 @@ export default function initBasedir(
     dots += '../';
     nm = path.resolve(here, dots, 'node_modules');
   }
-  fs.symlinkSync(nm, path.join(basedir, 'node_modules'));
+  fs.symlinkSync(nm, path.join(basedir, 'node_modules'), 'junction');
 
   // cosmos-sdk keypair
   if (egresses.includes('cosmos')) {

diff --git a/packages/cosmic-swingset/lib/ag-solo/start.js b/packages/cosmic-swingset/lib/ag-solo/start.js
@@ -38,7 +38,6 @@ let swingSetRunning = false;
 
 const fsWrite = promisify(fs.write);
 const fsClose = promisify(fs.close);
-const mkdir = promisify(fs.mkdir);
 const rename = promisify(fs.rename);
 const symlink = promisify(fs.symlink);
 const unlink = promisify(fs.unlink);
@@ -97,7 +96,7 @@ async function buildSwingset(
   });
 
   const pluginDir = path.resolve('./plugins');
-  await mkdir(pluginDir, { recursive: true });
+  fs.mkdirSync(pluginDir, { recursive: true });
   const pluginsPrefix = `${pluginDir}${path.sep}`;
   const pluginRequire = mod => {
     // Ensure they can't traverse out of the plugins prefix.
@@ -311,7 +310,7 @@ export default async function start(basedir, argv) {
 
   const agWallet = path.dirname(pjs);
   const agWalletHtml = path.resolve(agWallet, htmlBasedir);
-  symlink(agWalletHtml, 'html/wallet').catch(e => {
+  symlink(agWalletHtml, 'html/wallet', 'junction').catch(e => {
     console.error('Cannot link html/wallet:', e);
   });