Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix : review's Issue Template Bug #207 AgainIoT/Open-Set-Go#68 #208

Merged
merged 2 commits into from
Nov 4, 2023
Merged

Fix : review's Issue Template Bug #207 AgainIoT/Open-Set-Go#68 #208

merged 2 commits into from
Nov 4, 2023

Conversation

ymw0407
Copy link
Member

@ymw0407 ymw0407 commented Nov 4, 2023

Describe changes

Issue number or link

#207
AgainIoT/Open-Set-Go#68

Types of changes

What is the type of code change?
Put an x in the boxes that apply

  • Bugfix (changes that resolve errors)
  • New feature (changes which adds functionality)
  • Breaking change (big changes that affect existing functionality)
  • Documentation Update

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the "README.md"
  • My code follows the style guidelines of this project
  • My changes generate no new warnings
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation
  • Any dependent changes have been merged and published in downstream modules

Further comments

Please let me know if there's anything else to explain

ymw0407 and others added 2 commits November 4, 2023 14:33
@ymw0407
Chore : robots.txt typo error fixed
12adcca 
Signed-off-by: ymw0407 <yunminwo1211@gmail.com>
@ymw0407 @hwna00
Fix : Review feature's Issue template bug fixed at #207 AgainIoT/Open…
6ace86d 
…-Set-Go#68

Signed-off-by: ymw0407 <yunminwo1211@gmail.com>
Co-authored-by: hwna00 <layton3534@gmail.com>
@ymw0407 ymw0407 self-assigned this Nov 4, 2023
This was linked to issues Nov 4, 2023
🐛 [BUG] - review's Issue Template Bug AgainIoT/Open-Set-Go#68
Closed
🐛 [BUG]: review's Issue Template Bug #207
Closed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ymw0407 ymw0407 requested a review from a team November 4, 2023 06:28
@ymw0407 ymw0407 changed the title Fix : review's Issue Template Bug #206 AgainIoT/Open-Set-Go#68 Fix : review's Issue Template Bug #207 AgainIoT/Open-Set-Go#68 Nov 4, 2023
@hummingbbird hummingbbird self-requested a review November 4, 2023 06:34
hummingbbird
hummingbbird approved these changes Nov 4, 2023
View reviewed changes
Copy link
Contributor

@hummingbbird hummingbbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@ymw0407 ymw0407 merged commit 8d2b5ce into main Nov 4, 2023
7 checks passed
@ymw0407 ymw0407 deleted the feature/207 branch November 4, 2023 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hummingbbird hummingbbird hummingbbird approved these changes

@bentshrimp bentshrimp Awaiting requested review from bentshrimp

Assignees

@ymw0407 ymw0407

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 [BUG]: review's Issue Template Bug 🐛 [BUG] - review's Issue Template Bug
2 participants
@ymw0407 @hummingbbird