Merging multipeak updates with new preprocessing pipeline #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure the results get saved in the right place, etc.
…ferent voxel size.
…have detectable signal in reciprocal space, but were beyond the scan range in one or more dimensions.
Conflicts: cohere-scripts/beamlines/aps_34idc/beam_stuff.py cohere-scripts/multipeak.py
Multipeak
… size, rs and ds voxel size.
# Conflicts: # cohere-scripts/multipeak.py
# Conflicts: # cohere-scripts/beamline_visualization.py # cohere-scripts/multipeak.py # cohere-scripts/prep_helper.py # cohere-scripts/standard_preprocess.py
…rectory. It was trying to save to exp_dir/results_phasing/results_viz, when it should have been saving to exp_dir/results_viz
- Changed the rs_voxel_size to be the mean of the three dimensions, rather than the maximum. - Changed the ds_voxel_size to be defined by the final (resampled) image size rather than the initial (measured) image size.
… matplotlib cross sections
# Conflicts: # cohere-scripts/multipeak.py # cohere-scripts/prep_helper.py # cohere-scripts/run_reconstruction.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings the multipeak changes I've made into agreement with your new preprocessing pipeline (which I love, by the way!)