Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #15

Merged
merged 57 commits into from
Apr 24, 2024
Merged

Dev #15

merged 57 commits into from
Apr 24, 2024

Conversation

bfrosik
Copy link
Contributor

@bfrosik bfrosik commented Apr 24, 2024

Adding development branch for new release.

jacione and others added 27 commits December 8, 2023 11:37
* Updated multipeak phasing to work with direct phase/strain coupling

* A few bugfixes

Make sure the results get saved in the right place, etc.

* Fixed an oversight that allowed each rotated Bragg peak to have a different voxel size.

* Calculates correct voxel size for visualization

* Creates a mask which indicates post-interpolation pixels that likely have detectable signal in reciprocal space, but were beyond the scan range in one or more dimensions.

* Removed .idea directory from version control.

* Fixed broken path name (trying to load wrong config file)

* Refactored to record the B_recip matrix rather than applying the actual transform

* Add some additional useful information to the saved geometry: lattice size, rs and ds voxel size.

* Add some additional useful information to the saved geometry: final_size

* fixed crop issue

* Compatibility updates

* Fixed compatibility with Cohere's Dev branch

* Fixed bug that caused multipeak visualization to save in the wrong directory.

It was trying to save to exp_dir/results_phasing/results_viz, when it should have been saving to exp_dir/results_viz

---------

Co-authored-by: bfrosik <bfrosik@anl.gov>
@bfrosik bfrosik merged commit 1a703d1 into main Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants