fix: added multidevice support to query_active_history
#451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #451 +/- ##
==========================================
+ Coverage 24.22% 24.33% +0.11%
==========================================
Files 27 27
Lines 1540 1553 +13
Branches 251 256 +5
==========================================
+ Hits 373 378 +5
- Misses 1142 1150 +8
Partials 25 25
☔ View full report in Codecov by Sentry. |
ErikBjare
commented
May 29, 2023
src/queries.ts
Outdated
| } else { | ||
| const afkbucket: string = afkbuckets; | ||
| q = q.concat([ | ||
| `not_afk = union_no_overlap(not_afk, query_bucket("${escape_doublequote(afkbucket)}");`, |
There was a problem hiding this comment.
Suggested change
| `not_afk = union_no_overlap(not_afk, query_bucket("${escape_doublequote(afkbucket)}");`, | |
| `not_afk = union_no_overlap(not_afk, query_bucket("${escape_doublequote(afkbucket)}"));`, |
ErikBjare
commented
May 29, 2023
| let q = ['not_afk = [];']; | ||
| for (const afkbucket of afkbuckets) { | ||
| q = q.concat([ | ||
| `not_afk_curr = query_bucket("${escape_doublequote(afkbucket)}");`, |
There was a problem hiding this comment.
Suggested change
| `not_afk_curr = query_bucket("${escape_doublequote(afkbucket)}");`, | |
| `not_afk_curr = flood(query_bucket("${escape_doublequote(afkbucket)}"));`, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.