-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync stuff #89
Sync stuff #89
Conversation
ff4dc6c
to
a3a10f9
Compare
a3a10f9
to
7562921
Compare
Codecov Report
@@ Coverage Diff @@
## master #89 +/- ##
==========================================
- Coverage 60.85% 60.70% -0.15%
==========================================
Files 44 44
Lines 4989 5001 +12
==========================================
Hits 3036 3036
- Misses 1953 1965 +12
Continue to review full report at Codecov.
|
Rebasing on master somehow closed the PR as there was no longer a diff. I assume the commit had been cherrypicked or something? |
Got sync working using aw-client-rust. I've only tested syncing temporary databases to my local testing instance, but it seems to work! |
For some reason can't request a review from @xylix, but would be nice to have as many eyes on this as possible. |
Interesting that requesting doesn't work. I'll take a look around |
The code looks pretty good. What are the currently missing features? Is "See comments in #71 and fix them" not complete yet? |
This comment has been minimized.
This comment has been minimized.
@johan-bjareholt I've stumbled into an issue where I need to know the device ID for a remote bucket... Could you take a look at it so we can discuss options? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've stumbled into an issue where I need to know the device ID for a remote bucket... Could you take a look at it so we can discuss options?
Maybe just have a migration where we add a "host-id" row to all buckets? Then we could add the hosts ID to the already existing buckets.
Later on we could have a table for users to set their own names for each host instead of having a uuid for each maybe? And possibly even use the new key_value API for that.
dbad2f1
to
43d1d6a
Compare
285e0da
to
257be7c
Compare
@johan-bjareholt I think it's about time to merge this. There's work left but should be mergeable (assuming CI passes). Review plz. |
Merging this for now, as the CLI additions are needed for my PR in ErikBjare/quantifiedme#4 Will later continue the work in a new PR. |
Resuming work from #71
What's missing: