-
-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: switched to using poetry for make build
#379
Conversation
Having some CI trouble here... Switching to using poetry first caused it to create a venv for every subproject (since no venv was pre-activated on the windows or macOS builds), then I disabled that and ran into permission issues, and now I tried creating virtualenvs for both. We'll see how it goes, at least the Linux build seems to be working. |
make build
Things finally seem to be working. Fingers crossed. Edit: Apart from venv activation on Windows in Travis. Should be fixed now. |
Is the problem in appveyor related to the order the packages are installed? |
No, I think it has to do with that python3 doesn't exist in the virtualenv (only |
…updated submodule with 64bit pyhook fix
I think I've finally hunted down the last uses of |
Fuck yes, Appveyor passing. Hoping everything finally passes... |
Good luck to that. I'll be working on the new macos issue(s) tomorrow afternoon |
@xylix Amazing work with the macOS stuff btw, looks like it's just a few minor things left :) If you feel like doing work on sync, feel free to check out ActivityWatch/aw-server-rust#89, or try getting into and make some improvements to the web UI. |
The Windows build on Travis (https://travis-ci.org/github/ActivityWatch/activitywatch/jobs/664524794) didn't quit even though it was successfully done. Failed due to the timeout, but it works! |
@johan-bjareholt Do you have any idea of what might be stalling the Windows build? |
No idea, but I'd try replacing the "kill %1" stuff with the following This might also come in handy for debugging what's still running, never tried it though and you need to mail travis to get access apparently. https://docs.travis-ci.com/user/running-build-in-debug-mode/#enabling-debug-mode |
The problem with Edit: Also, the command clearly exited: |
I just went ahead and restarted the build, since we had some issues with the macOS builds around the same time and there shouldn't really be any new processes spawned in the background from the last passing commit. Hopefully that'll work. |
https://travis-ci.community/t/build-timeout-but-actually-succeeded/2763 This talks about yarn but is it possible poetry starts some similarish background processes like gpg which prevent the windows box from shutting down? Would be really weird that it only happens on windows though... If it's some weird background process ps could show it and for loop killing all processes should fix it. That's a very hacky solution though :/ |
Since Windows timeout is now the only thing failing CI, I've decided to add Windows Travis to Windows on Travis isn't used for deployment yet anyway, so it doesn't need to work perfectly for us to move forward and merge this PR. |
Alright, all green. Here we go. |
make build
make build
make build
now usespoetry install
to install all Python packages and dependencies. This makes CI actually use thepoetry.lock
files to resolve dependencies (whichpip install .
doesn't).It also:
python3
topython
(sincepython3
isn't available on Windows)Fixes #378