added stricter joining of annotated fields #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Context here is that the preprocessor runs all the python expressions and then concatenates them. If they are all pandas with the same index, they'll get joined together no problem. However, if for example it's an array that gets turned back into a pandas series but now has a different order, it'll be scrambled when you try to join them. In other words, this PR helps prevent users from an incorrect merge when writing complicated preprocessor expressions. |
|
This PR seems like a great candidate for "show me in a unit test". Can we do that in a timely manner here? |
|
Unit test added and passing. Ready for your review @jpn--. |
jpn--
approved these changes
Feb 8, 2024
jpn--
force-pushed
the
annotate_bugfix
branch
from
70ab2cc
to
a3f60a4
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a check to prevent out of order pandas series from being concatenated improperly. If there is an index in the panda series then it is reindexed to match the final data frame, otherwise skip.