Flexible Number of Tour & Trip IDs #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All of the changes present in this pull request are also implemented in the school escorting pull request. The school escorting pull request also includes additional changes to this part of the code to add "tour flavors" for school escorting. |
JoeJimFlood
suggested changes
Oct 24, 2022
There was a problem hiding this comment.
Looks great! A couple comments on canonical_ids.py:
- The functions
read_alts_file()andread_spec_file()are identical. Was this intentional? - I know I'm being a bit nitpicky here, but the comment in Line 445 reflects the code before this change when
MAX_TRIPS_PER_LEGwas hard-coded. I'm concerned that this might confuse future developers. Possibly have it say1st in = max_trips_per_leg + 1or something like that?
|
Thanks for your comments Joe. And please continue to be "nitpicky" as that is what we need in these reviews! I have removed the deuplicative read_spec_file() and left the read_alts_file() in place. The comment has been updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes the hard coded max number of trips and tours available in ActivitySim. For details, see the presentation here and scope here.