Write Number of Participants to Trip List Output #372
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a convenience method, the ARC Cube scripts need a way to expand the output trip lists based on the number of participants. This pull request adds an additional field "number_of_participants" to the final_trips.csv. It is a mirror of the similar value on the final_tours.csv.
This PR also removes a vestigal time_period_label method that had been replaced the new Network LOS class.
Review Criteria Responses
Does it contain all the required elements, including a runnable example, documentation, and tests?
The examples are updated with the appropriate configuration changes. No new documentation is necessary. No new tests were created, but the existing tests all pass.
Does it implement good methods (i.e. is it consistent with good practices in travel modeling)?
Yes, it provides more flexibility to support trip table expansion without necessitating table joins. This extends the spirit of the ActivitySim project to provide maximum implementation flexibility while maintaining a common workflow and model specification.
Are the runtimes reasonable and does it provide documentation justifying this claim?
This change has no material impact on runtimes.
Does it include non-Python code, such as C/C++? If so, does it compile on any OS and are compilation instructions included?
No. This is a Python-only change.
Is it licensed with the ActivitySim license that allows the code to be freely distributed and modified and includes attribution so that the ‘provenance’ of the code can be tracked? Does it include an official release of ownership from the funding agency if applicable?
This work was done under contract to ARC, and, presumably, ARC is providing the changes without any additional licensing beyond the existing ActivitySim licensing.
Does it appropriately interact with the data pipeline (i.e. it doesn't create new ways of managing data)?
This change requires a change to the data pipeline to deal with redundant field names in downstream models. The examples have been updated.
Does it include regression tests to enable checking that consistent results will be returned when updates are made to the framework?
No regression testing has been done. The code change removes a hard-coded value in the Python code with a set of user-defined variables. If the user specifies the same values as the previously hard-coded values, they should get the same results. The unit tests seem to confirm this assertion.
Does it include sufficient test coverage and test data for existing and proposed features?
The test configuration files were modified to use the newest features.
Any other comments or suggestions for improving the developer experience?
No. This is pretty straightforward.