forked from nus-cs2103-AY2324S1/tp
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct existing error message #262
Merged
GlendaChong
merged 5 commits into
AY2324S1-CS2103T-T17-2:master
from
tayruxin:CodeQuality
Nov 12, 2023
Merged
Correct existing error message #262
GlendaChong
merged 5 commits into
AY2324S1-CS2103T-T17-2:master
from
tayruxin:CodeQuality
Nov 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tayruxin
requested review from
GlendaChong,
AlagappanRa,
papataco14 and
alientian
November 12, 2023 05:06
Codecov Report
@@ Coverage Diff @@
## master #262 +/- ##
=========================================
Coverage 74.14% 74.14%
Complexity 579 579
=========================================
Files 88 88
Lines 1895 1895
Branches 220 220
=========================================
Hits 1405 1405
Misses 409 409
Partials 81 81
|
GlendaChong
changed the title
Correct exisitng error message
Correct existing error message
Nov 12, 2023
GlendaChong
approved these changes
Nov 12, 2023
GlendaChong
requested changes
Nov 12, 2023
GlendaChong
approved these changes
Nov 12, 2023
@@ -18,7 +18,7 @@ public class Messages { | |||
+ "Please follow the command format below and try again! \n%1$s"; | |||
|
|||
public static final String MESSAGE_INVALID_COMPANY_DISPLAYED_INDEX = | |||
"Oops! You have entered an index that is greater than the number of companies that you have. " | |||
"Oops! You have entered an index that is greater than the number of companies that you have in the list. " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe say "current list" for clarify?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous error message for edit displays incorrect information.