Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct existing error message #262

Merged
merged 5 commits into from
Nov 12, 2023

Conversation

tayruxin
Copy link
Collaborator

The previous error message for edit displays incorrect information.

Copy link

codecov bot commented Nov 12, 2023

Codecov Report

Merging #262 (43f6819) into master (e6758d1) will not change coverage.
Report is 16 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #262   +/-   ##
=========================================
  Coverage     74.14%   74.14%           
  Complexity      579      579           
=========================================
  Files            88       88           
  Lines          1895     1895           
  Branches        220      220           
=========================================
  Hits           1405     1405           
  Misses          409      409           
  Partials         81       81           
Files Coverage Δ
src/main/java/seedu/address/logic/Messages.java 45.71% <ø> (ø)
...java/seedu/address/logic/commands/EditCommand.java 94.23% <100.00%> (ø)

... and 2 files with indirect coverage changes

@GlendaChong GlendaChong changed the title Correct exisitng error message Correct existing error message Nov 12, 2023
@@ -18,7 +18,7 @@ public class Messages {
+ "Please follow the command format below and try again! \n%1$s";

public static final String MESSAGE_INVALID_COMPANY_DISPLAYED_INDEX =
"Oops! You have entered an index that is greater than the number of companies that you have. "
"Oops! You have entered an index that is greater than the number of companies that you have in the list. "
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe say "current list" for clarify?

@GlendaChong GlendaChong merged commit f02c4fd into AY2324S1-CS2103T-T17-2:master Nov 12, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants