Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robust sysinfo #16173

Merged
merged 10 commits into from
Jul 20, 2024
Merged

Robust sysinfo #16173

merged 10 commits into from
Jul 20, 2024

Conversation

w-e-w
Copy link
Collaborator

@w-e-w w-e-w commented Jul 8, 2024

Description

make sysinfo more robust

change

  • fix when using commang line arg --dump-sysinfo some info are missing
    • Implement fallback methods and or error handling when retrieving a certain information
  • restructure import with error handling
    • move complex modules such as shared and extensions into function level input
    • use shared_cmd_options over shared.cmd_opts for cmd_opts
  • add new info git -C <webui_rooot> status
    • this provide information on the better or not there is non-committed changes to the code base
    • using pip freeze --all with importlib.metadata as fallback for listing pacages
    • pip freeze provides extra information such as if the package was installed via a custom wheel URL as opposed to only the version, example:
      "triton @ https://github.com/aaa/bbb/releases/download/v1/xxx.whl#sha256=abcde",
    • importlib.metadata because pkg_resources is being deprecated
  • .gitignore /sysinfo-????-??-??-??-??.json
    • file is created when using --dump-sysinfo

idea
including ui-config.json might be valuable as well


discussion

I think the term sysinfo is confusing in boath the UI and in the issue post template
I belive this increases the chance of those who don't read carefully to just onput something like

Windows
Nvidia
Chrome

as opposed to a generating and uploading the sysinfo we want
I think something like diagnosis info debug info might work better

most likely they're a better terms then the ones I came up with

Checklist:

@w-e-w w-e-w requested a review from AUTOMATIC1111 as a code owner July 8, 2024 17:30
@AUTOMATIC1111 AUTOMATIC1111 merged commit 5096c16 into dev Jul 20, 2024
6 checks passed
@AUTOMATIC1111 AUTOMATIC1111 deleted the robust-sysinfo branch July 20, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants