Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use script_path for webui root in launch_utils #15705

Merged
merged 1 commit into from
Jun 8, 2024
Merged

use script_path for webui root in launch_utils #15705

merged 1 commit into from
Jun 8, 2024

Conversation

w-e-w
Copy link
Collaborator

@w-e-w w-e-w commented May 4, 2024 •
edited
Loading

Description

webui modules like launch to be imported correctly in extensions install.py when user run webui from a different cwd then webui root
fix

more sensible implementation of what is trying to achieve

script_path is difined relative to modules/paths_internal.p so won't be affected by cwd like the current os.path.abspath('.')

stable-diffusion-webui/modules/paths_internal.py

Lines 16 to 17 in 1c0a0c4

modules_path = os.path.dirname(os.path.realpath(__file__))
script_path = os.path.dirname(modules_path)

additional
also change the path for CHANGELOG.md

Checklist:

@w-e-w w-e-w requested a review from AUTOMATIC1111 as a code owner May 4, 2024 14:48
@w-e-w w-e-w mentioned this pull request May 4, 2024
Closed
4 tasks
@AUTOMATIC1111 AUTOMATIC1111 merged commit b9dfc50 into dev Jun 8, 2024
6 checks passed
@AUTOMATIC1111 AUTOMATIC1111 deleted the use-script_path-for-webui-root-in-launch_utils branch June 8, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AUTOMATIC1111 AUTOMATIC1111 AUTOMATIC1111 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@w-e-w @AUTOMATIC1111