Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open_folder as util #15442

Merged
merged 3 commits into from
Apr 6, 2024
Merged

open_folder as util #15442

merged 3 commits into from
Apr 6, 2024

Conversation

w-e-w
Copy link
Collaborator

@w-e-w w-e-w commented Apr 5, 2024

Description

extract the open_folder in ui_common.create_output_panel as a util so it can be resues by extensions

I've seen several instances of extensions needing the same open_folder function but couldn't reuse the one in webui because it's in create_output_panel, they endend up haveing to essentially copy and paste and create a new function

I import the modules at function level and not module level because feel especially gradio import would cause issues

Checklist:

@w-e-w w-e-w changed the base branch from master to dev April 5, 2024 07:08
@AUTOMATIC1111 AUTOMATIC1111 merged commit 447198f into dev Apr 6, 2024
6 checks passed
@AUTOMATIC1111 AUTOMATIC1111 deleted the open_folder-as-util branch April 6, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants