Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add self to CFGDenoiserParams #14573

Merged

Conversation

continue-revolution
Copy link
Contributor

@continue-revolution continue-revolution commented Jan 7, 2024

Description

This PR aim for adding CFGDenoiser itself as a parameter inside CFGDenoiserParams so that I am able to retrieve my script arguments and something else if I want to add a callback.

Checklist:

@continue-revolution continue-revolution changed the title add p to cfgdenoiserparams add p to CFGDenoiserParams Jan 7, 2024
@continue-revolution continue-revolution marked this pull request as draft January 7, 2024 16:33
@continue-revolution continue-revolution marked this pull request as ready for review January 7, 2024 18:35
@continue-revolution continue-revolution changed the title add p to CFGDenoiserParams Add self to CFGDenoiserParams Jan 7, 2024
@AUTOMATIC1111
Copy link
Owner

Some extensions use this class to in their own code, so adding it like this will break them. Let's make the denoiser argument None by default.

@AUTOMATIC1111 AUTOMATIC1111 merged commit 6869d95 into AUTOMATIC1111:dev Jan 8, 2024
3 checks passed
@continue-revolution continue-revolution deleted the conrevo/add-p-to-cfg branch January 8, 2024 11:04
@w-e-w w-e-w mentioned this pull request Feb 17, 2024
@pawel665j pawel665j mentioned this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants