Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging configuration again #14538

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Conversation

akx
Copy link
Collaborator

@akx akx commented Jan 4, 2024

Description

Post #13996, debug logging wouldn't work correctly. This makes it work correctly, and then some:

  • Only use tqdm.write() if tqdm is active, defer to stderr
  • Correct log formatter for TqdmLoggingHandler
  • If rich is installed and SD_WEBUI_RICH_LOG is set, use rich's formatter.

Screenshots/videos:

The rich log can look like

Screenshot 2024-01-04 at 19 33 47

Checklist:

* Only use `tqdm.write()` if `tqdm` is active, defer to stderr
* Correct log formatter for TqdmLoggingHandler
* If `rich` is installed and `SD_WEBUI_RICH_LOG` is set, use `rich`'s formatter
@AUTOMATIC1111 AUTOMATIC1111 merged commit a06dab8 into AUTOMATIC1111:dev Jan 5, 2024
3 checks passed
@w-e-w w-e-w mentioned this pull request Feb 17, 2024
@pawel665j pawel665j mentioned this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants