Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be more clear about Spandrel model nomenclature and types #14477

Merged
merged 2 commits into from
Dec 30, 2023
Merged

Be more clear about Spandrel model nomenclature and types #14477

merged 2 commits into from
Dec 30, 2023

Conversation

akx
Copy link
Collaborator

@akx akx commented Dec 30, 2023

Description

Depending on the value of half and dtype, load_spandrel_model could have returned a torch.Module instead of a spandrel.ModelDescriptor. Now it's certain to only return a descriptor (and typed as such).

Follows up on 3be9074 8100e90 somewhat...

Checklist:

@akx akx marked this pull request as ready for review December 30, 2023 22:24
@AUTOMATIC1111 AUTOMATIC1111 merged commit ce21840 into AUTOMATIC1111:dev Dec 30, 2023
3 checks passed
@w-e-w w-e-w mentioned this pull request Feb 17, 2024
Closed
@pawel665j pawel665j mentioned this pull request Apr 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AUTOMATIC1111 AUTOMATIC1111 AUTOMATIC1111 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akx @AUTOMATIC1111