Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More lora not found warning #14464

Merged
merged 1 commit into from
Dec 30, 2023
Merged

More lora not found warning #14464

merged 1 commit into from
Dec 30, 2023

Conversation

w-e-w
Copy link
Collaborator

@w-e-w w-e-w commented Dec 30, 2023

Description

[Feature Request]: Reinstate Lora, etc output warnings in Log window #14463
related discussion #14455 (comment)

  • Add more options to show that Lora network is not found
  1. in console
  2. using gradio Warning

controlled respectively by settings
Settings > Extra Networks > Lora not found warning in console
Settings > Extra Networks > Lora not found popup warning in webui

  • reword the message Lora and not and not just generic Network

not sure if these option should be enabled or disabled by default
if this is going to be merged please decide what should be the default value before merging


an alternative solution to this is to just change the loglevel to warning

logging.info(f"Couldn't find network with name {name}")

Screenshots/videos:

image
image

Checklist:

@w-e-w w-e-w linked an issue Dec 30, 2023 that may be closed by this pull request
1 task
@AUTOMATIC1111 AUTOMATIC1111 merged commit 32862e4 into dev Dec 30, 2023
6 checks passed
@AUTOMATIC1111 AUTOMATIC1111 deleted the more-lora-not-found-warning branch December 30, 2023 11:04
@w-e-w w-e-w mentioned this pull request Feb 17, 2024
@pawel665j pawel665j mentioned this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Reinstate Lora, etc output warnings in Log window
2 participants