Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only rewrite ui-config when there is change #14352

Merged
merged 1 commit into from
Jan 1, 2024

Conversation

w-e-w
Copy link
Collaborator

@w-e-w w-e-w commented Dec 18, 2023

  • only rewrite ui-config on load when there is change

ui-config.json is is always rewritten on webui load, even when there's no change
there's no point and can cause file corruption if webui is killed at a inappropriate time during load

and yes I was unlucky enough that this actually happened to me

Changes

  • create a copy of the dictionary read from file and compare before writing if there is no change then don't write the file
  • a minor typo fix

Checklist:

@AUTOMATIC1111 AUTOMATIC1111 merged commit 0ce67cb into dev Jan 1, 2024
6 checks passed
@AUTOMATIC1111 AUTOMATIC1111 deleted the reduce-unnecessary-ui-config-write branch January 1, 2024 13:35
@w-e-w w-e-w mentioned this pull request Feb 17, 2024
@pawel665j pawel665j mentioned this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants