Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to show batch img2img results in UI #14009

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

w-e-w
Copy link
Collaborator

@w-e-w w-e-w commented Nov 17, 2023

Description

add settings Settings > img2img > Show the first N batch img2img results in UI
this option allows the user to control the amount of images to return to the UI when performing batch img2img
images up to is it amount will be shown when performing batch img2img, this prevents webui from trying to display too many images and having to keep them all in memory

this is similar to how extras tab have an option to show resulting image
I've only noticed that there's no option to do this because there was an extension submission
AUTOMATIC1111/stable-diffusion-webui-extensions#231

from my testing gen info should be correct
and should works with script, tested with XYZ grid

default set to 32 images

set 0 to disable, -1 for unlimited

Screenshots/videos

image
image

outdated

add option to show batch img2img results in UI, default disabled

user can be set to default enabled ui-config / Default system

Screenshots/videos:

image

Checklist:

@AUTOMATIC1111
Copy link
Owner

Wouldn't this work better as a setting?

@w-e-w
Copy link
Collaborator Author

w-e-w commented Nov 19, 2023

Wouldn't this work better as a setting?

yes, and I did consider that too after submitting the PR
it would make the code simpler passing through lesser layers of functions

in settings I would also have space of an extra option, limit on the maximum number of images showed
as return too many images can cause lag

shared.opts.img2img_batch_show_results_limit
limit the number of images return to the UI for batch img2img
default limit 32
0 no images are shown
-1 unlimited, all images are shown
@w-e-w w-e-w force-pushed the Option-to-show-batch-img2img-results-in-UI branch from fa1a4d2 to dea5e43 Compare November 19, 2023 08:37
@w-e-w
Copy link
Collaborator Author

w-e-w commented Nov 19, 2023

Updated

@AUTOMATIC1111 AUTOMATIC1111 merged commit 5f36f6a into dev Nov 20, 2023
6 checks passed
@AUTOMATIC1111 AUTOMATIC1111 deleted the Option-to-show-batch-img2img-results-in-UI branch November 20, 2023 14:45
@w-e-w w-e-w mentioned this pull request Dec 4, 2023
@w-e-w w-e-w mentioned this pull request Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants