Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finer settings freezing control #13789

Merged

Conversation

nickpharrison
Copy link
Contributor

Description

I have a use-case where I would like to control which settings users can change. I share my instance with friends whom I trust (hence no authentication issues) but I do not want them to accidentally change certain settings.

The --freeze-settings parameter is not suitable because there are some settings which they should be able to change (such as the currently used checkpoint), and the --hide-ui-dir-config is only applicable for a small subset of settings (plus this setting as HIDES the settings completely, which I do not necessarily want to do.

The solution I suggest (and have implemented so far) is:

  • allow users to use --freeze-settings to globally stop settings being changed
  • otherwise, specify a list to UI "sections" where they can freeze whole tabs of settings from being edited (as defined in modules/shared_options.py). This can be done by specifying a comma-delimited list in the new command line option --freeze-settings-in-sections
  • also allow users to prevent individual settings from being edited if they don't want to freeze. This can be done by specifying a comma-delimited list in the new command line option --freeze-specific-settings

The changes to the code add the two new options to the known commands list (in modules/cmd_args.py) and add additional assertions when setting new settings (in the same way as --freeze-settings does)

Example options for testing:

--freeze-settings-in-sections API,system --freeze-specific-settings samples_save

Screenshots/videos:

Screenshot from 2023-10-29 15-54-12
Screenshot from 2023-10-29 15-53-45

Checklist:

@AUTOMATIC1111
Copy link
Owner

you lost some settings/reverted some changes in modules/cmd_args.py.

@AUTOMATIC1111 AUTOMATIC1111 merged commit c507d7b into AUTOMATIC1111:dev Jan 1, 2024
2 of 3 checks passed
AUTOMATIC1111 added a commit that referenced this pull request Jan 1, 2024
@w-e-w w-e-w mentioned this pull request Feb 17, 2024
@pawel665j pawel665j mentioned this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants