Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Characteristic_Guidance_Web_UI.json #253

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

scraed
Copy link
Contributor

@scraed scraed commented Dec 28, 2023

Characteristic_Guidance_Web_UI

New guidance method providing large CFG scale correction for classifier-free guidance. Compatible with existing sampling methods.

Info

Checklist:

  • I have read the Readme.md
  • The description is written in English.
  • The index.json and extension_template.json have not been modified.
  • The entry is placed in the extensions directory with the .json file extension.

new extension: Characteristic_Guidance_Web_UI
@w-e-w
Copy link
Collaborator

w-e-w commented Jan 3, 2024

hi sorry took awhile for me to start merging extension to index

I have tested your extension and it does work so it can be added
but there are some issues that I will prefer that you sorted out before it gets merged I've sent over a PR with explanations
scraed/CharacteristicGuidanceWebUI#1

basically if you merge my PR that you should be solved
but please check my PR aligns with your ideals and verify the functionality does work before you merge it

@w-e-w w-e-w self-assigned this Jan 3, 2024
@w-e-w
Copy link
Collaborator

w-e-w commented Jan 3, 2024

I remove tab extras tag and added science
seems more fitting
see https://github.com/AUTOMATIC1111/stable-diffusion-webui-extensions/blob/extensions/tags.json

@w-e-w
Copy link
Collaborator

w-e-w commented Jan 4, 2024

@scraed
nice I see you have made some changes the keys names used
scraed/CharacteristicGuidanceWebUI@3188027

are the key names final
I want to confirm because it's better that you finalize them before I merge this into index

@scraed
Copy link
Contributor Author

scraed commented Jan 4, 2024

@w-e-w Yes, I have merged the PR to fix the infotext issue with some name changes. I think they are final. Thanks again for your PR!

@w-e-w w-e-w merged commit 18271ed into AUTOMATIC1111:extensions Jan 4, 2024
1 check passed
@w-e-w
Copy link
Collaborator

w-e-w commented Jan 4, 2024

great

github-actions bot pushed a commit that referenced this pull request Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants