Temporary disable Crypto HW accelerator on UBLOX_EVK_ODIN_W2 #10088

alekshex · 2019-03-13T16:49:00Z

Description

Temporary disable work with Crypto HW accelerator on STM32F439xI chipset due to possible issue with it.
Switch to SW only.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[X] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@Patater @netanelgonen @NirSonnenschein

Release Notes

for 5.12rc3

Attached full compliance tests log:

target	platform_name	test suite	result	elapsed_time (sec)	copy_method
UBLOX_EVK_ODIN_W2-GCC_ARM	UBLOX_EVK_ODIN_W2	components-target_psa-tests-compliance_attestation-test_a001	OK	28.09	default
UBLOX_EVK_ODIN_W2-GCC_ARM	UBLOX_EVK_ODIN_W2	components-target_psa-tests-compliance_crypto-test_c001	OK	18.37	default
UBLOX_EVK_ODIN_W2-GCC_ARM	UBLOX_EVK_ODIN_W2	components-target_psa-tests-compliance_crypto-test_c002	OK	19.38	default
UBLOX_EVK_ODIN_W2-GCC_ARM	UBLOX_EVK_ODIN_W2	components-target_psa-tests-compliance_crypto-test_c003	OK	19.29	default
UBLOX_EVK_ODIN_W2-GCC_ARM	UBLOX_EVK_ODIN_W2	components-target_psa-tests-compliance_crypto-test_c004	OK	19.26	default
UBLOX_EVK_ODIN_W2-GCC_ARM	UBLOX_EVK_ODIN_W2	components-target_psa-tests-compliance_crypto-test_c005	OK	19.26	default
UBLOX_EVK_ODIN_W2-GCC_ARM	UBLOX_EVK_ODIN_W2	components-target_psa-tests-compliance_crypto-test_c006	OK	20.18	default
UBLOX_EVK_ODIN_W2-GCC_ARM	UBLOX_EVK_ODIN_W2	components-target_psa-tests-compliance_crypto-test_c007	OK	23.36	default
UBLOX_EVK_ODIN_W2-GCC_ARM	UBLOX_EVK_ODIN_W2	components-target_psa-tests-compliance_crypto-test_c008	OK	19.31	default
UBLOX_EVK_ODIN_W2-GCC_ARM	UBLOX_EVK_ODIN_W2	components-target_psa-tests-compliance_crypto-test_c009	OK	19.09	default
UBLOX_EVK_ODIN_W2-GCC_ARM	UBLOX_EVK_ODIN_W2	components-target_psa-tests-compliance_crypto-test_c010	OK	19.25	default
UBLOX_EVK_ODIN_W2-GCC_ARM	UBLOX_EVK_ODIN_W2	components-target_psa-tests-compliance_crypto-test_c011	OK	19.38	default
UBLOX_EVK_ODIN_W2-GCC_ARM	UBLOX_EVK_ODIN_W2	components-target_psa-tests-compliance_crypto-test_c012	OK	19.19	default
UBLOX_EVK_ODIN_W2-GCC_ARM	UBLOX_EVK_ODIN_W2	components-target_psa-tests-compliance_crypto-test_c013	OK	18.73	default
UBLOX_EVK_ODIN_W2-GCC_ARM	UBLOX_EVK_ODIN_W2	components-target_psa-tests-compliance_crypto-test_c014	OK	18.98	default
UBLOX_EVK_ODIN_W2-GCC_ARM	UBLOX_EVK_ODIN_W2	components-target_psa-tests-compliance_crypto-test_c015	OK	18.82	default
UBLOX_EVK_ODIN_W2-GCC_ARM	UBLOX_EVK_ODIN_W2	components-target_psa-tests-compliance_crypto-test_c016	OK	19.32	default
UBLOX_EVK_ODIN_W2-GCC_ARM	UBLOX_EVK_ODIN_W2	components-target_psa-tests-compliance_crypto-test_c017	OK	18.98	default
UBLOX_EVK_ODIN_W2-GCC_ARM	UBLOX_EVK_ODIN_W2	components-target_psa-tests-compliance_crypto-test_c018	OK	18.53	default
UBLOX_EVK_ODIN_W2-GCC_ARM	UBLOX_EVK_ODIN_W2	components-target_psa-tests-compliance_crypto-test_c019	OK	18.21	default
UBLOX_EVK_ODIN_W2-GCC_ARM	UBLOX_EVK_ODIN_W2	components-target_psa-tests-compliance_crypto-test_c020	OK	18.91	default
UBLOX_EVK_ODIN_W2-GCC_ARM	UBLOX_EVK_ODIN_W2	components-target_psa-tests-compliance_crypto-test_c021	OK	18.56	default
UBLOX_EVK_ODIN_W2-GCC_ARM	UBLOX_EVK_ODIN_W2	components-target_psa-tests-compliance_crypto-test_c022	OK	19.41	default
UBLOX_EVK_ODIN_W2-GCC_ARM	UBLOX_EVK_ODIN_W2	components-target_psa-tests-compliance_crypto-test_c023	OK	18.78	default
UBLOX_EVK_ODIN_W2-GCC_ARM	UBLOX_EVK_ODIN_W2	components-target_psa-tests-compliance_crypto-test_c024	OK	19.26	default
UBLOX_EVK_ODIN_W2-GCC_ARM	UBLOX_EVK_ODIN_W2	components-target_psa-tests-compliance_crypto-test_c025	OK	19.15	default
UBLOX_EVK_ODIN_W2-GCC_ARM	UBLOX_EVK_ODIN_W2	components-target_psa-tests-compliance_crypto-test_c026	OK	19.04	default
UBLOX_EVK_ODIN_W2-GCC_ARM	UBLOX_EVK_ODIN_W2	components-target_psa-tests-compliance_crypto-test_c027	OK	18.42	default
UBLOX_EVK_ODIN_W2-GCC_ARM	UBLOX_EVK_ODIN_W2	components-target_psa-tests-compliance_crypto-test_c028	OK	18.44	default
UBLOX_EVK_ODIN_W2-GCC_ARM	UBLOX_EVK_ODIN_W2	components-target_psa-tests-compliance_crypto-test_c029	OK	18.83	default
UBLOX_EVK_ODIN_W2-GCC_ARM	UBLOX_EVK_ODIN_W2	components-target_psa-tests-compliance_crypto-test_c030	OK	19.11	default
UBLOX_EVK_ODIN_W2-GCC_ARM	UBLOX_EVK_ODIN_W2	components-target_psa-tests-compliance_crypto-test_c031	OK	18.7	default
UBLOX_EVK_ODIN_W2-GCC_ARM	UBLOX_EVK_ODIN_W2	components-target_psa-tests-compliance_crypto-test_c032	OK	19.78	default
UBLOX_EVK_ODIN_W2-GCC_ARM	UBLOX_EVK_ODIN_W2	components-target_psa-tests-compliance_crypto-test_c033	OK	19.87	default
UBLOX_EVK_ODIN_W2-GCC_ARM	UBLOX_EVK_ODIN_W2	components-target_psa-tests-compliance_crypto-test_c034	OK	18.78	default
UBLOX_EVK_ODIN_W2-GCC_ARM	UBLOX_EVK_ODIN_W2	components-target_psa-tests-compliance_crypto-test_c035	OK	19.72	default
UBLOX_EVK_ODIN_W2-GCC_ARM	UBLOX_EVK_ODIN_W2	components-target_psa-tests-compliance_crypto-test_c036	OK	19.7	default
UBLOX_EVK_ODIN_W2-GCC_ARM	UBLOX_EVK_ODIN_W2	components-target_psa-tests-compliance_crypto-test_c037	OK	20.51	default
UBLOX_EVK_ODIN_W2-GCC_ARM	UBLOX_EVK_ODIN_W2	components-target_psa-tests-compliance_crypto-test_c038	OK	19.12	default
UBLOX_EVK_ODIN_W2-GCC_ARM	UBLOX_EVK_ODIN_W2	components-target_psa-tests-compliance_crypto-test_c039	OK	19.33	default
UBLOX_EVK_ODIN_W2-GCC_ARM	UBLOX_EVK_ODIN_W2	components-target_psa-tests-compliance_crypto-test_c040	OK	19.78	default
UBLOX_EVK_ODIN_W2-GCC_ARM	UBLOX_EVK_ODIN_W2	components-target_psa-tests-compliance_crypto-test_c041	OK	20.49	default
UBLOX_EVK_ODIN_W2-GCC_ARM	UBLOX_EVK_ODIN_W2	components-target_psa-tests-compliance_crypto-test_c042	OK	21.27	default
UBLOX_EVK_ODIN_W2-GCC_ARM	UBLOX_EVK_ODIN_W2	components-target_psa-tests-compliance_crypto-test_c043	OK	21.21	default
UBLOX_EVK_ODIN_W2-GCC_ARM	UBLOX_EVK_ODIN_W2	components-target_psa-tests-compliance_its-test_s001	OK	19.65	default
UBLOX_EVK_ODIN_W2-GCC_ARM	UBLOX_EVK_ODIN_W2	components-target_psa-tests-compliance_its-test_s002	OK	19.88	default
UBLOX_EVK_ODIN_W2-GCC_ARM	UBLOX_EVK_ODIN_W2	components-target_psa-tests-compliance_its-test_s004	OK	19.37	default
UBLOX_EVK_ODIN_W2-GCC_ARM	UBLOX_EVK_ODIN_W2	components-target_psa-tests-compliance_its-test_s005	OK	19.34	default
UBLOX_EVK_ODIN_W2-GCC_ARM	UBLOX_EVK_ODIN_W2	components-target_psa-tests-compliance_its-test_s006	OK	19.09	default
UBLOX_EVK_ODIN_W2-GCC_ARM	UBLOX_EVK_ODIN_W2	components-target_psa-tests-compliance_its-test_s007	OK	19.31	default
UBLOX_EVK_ODIN_W2-GCC_ARM	UBLOX_EVK_ODIN_W2	components-target_psa-tests-compliance_its-test_s008	OK	19.23	default
UBLOX_EVK_ODIN_W2-GCC_ARM	UBLOX_EVK_ODIN_W2	components-target_psa-tests-compliance_its-test_s009	OK	19.38	default
UBLOX_EVK_ODIN_W2-GCC_ARM	UBLOX_EVK_ODIN_W2	components-target_psa-tests-compliance_its-test_s010	OK	19.2	default
mbedgt: test suite results: 53 OK

Patater · 2019-03-13T16:54:36Z

Do we know if STM32F439ZI is also affected? Both boards use the same accelerator.

alekshex · 2019-03-13T17:19:32Z

Do we know if STM32F439ZI is also affected? Both boards use the same accelerator.

Currently no failures except Odin board were reported.
@NirSonnenschein do we run other STM32F439ZI chipset boards in except Odin CI?

ciarmcom · 2019-03-13T18:00:46Z

@avolinski, thank you for your changes.
@netanelgonen @NirSonnenschein @Patater @ARMmbed/mbed-os-crypto @ARMmbed/mbed-os-maintainers please review.

NirSonnenschein · 2019-03-13T19:32:31Z

@avolinski here is the list of boards on the nightly job, I'm not sure if any additional ones use the STM32F439ZI chipset :
ARCH_PRO
CY8CKIT_062_WIFI_BT
DISCO_F746NG
DISCO_L475VG_IOT01A
EV_COG_AD3029LZ
EV_COG_AD4050LZ
K22F
K64F
K66F
K66F-ESP8266
K82F
KW24D
KW41Z
NRF51_DK
NRF52_DK
NUCLEO_F072RB
NUCLEO_F207ZG
NUCLEO_F429ZI
NUCLEO_F746ZG
NUCLEO_F767ZI
NUCLEO_L073RZ
UBLOX_EVK_ODIN_W2

NirSonnenschein · 2019-03-13T19:36:10Z

This approach seems better than removing PSA support altogether, however we could be causing a performance degradation (possibly a big one) if this functionality is used in non-psa scenarios so there may be a bit of risk involved here as well

NirSonnenschein · 2019-03-14T07:24:15Z

starting CI pending reviews

netanelgonen

What is the reason that we need to disable sha1 and md5 for AES and attestation?

Alonof · 2019-03-14T07:57:09Z

features/mbedtls/targets/TARGET_STM/TARGET_STM32F4/TARGET_STM32F439xI/mbedtls_device.h


-#define MBEDTLS_SHA1_ALT
+//#define MBEDTLS_SHA1_ALT


@avolinski

Why removing SHA1 & MD5

Why not add a fix to the H/W driver? did you look at the spec maybe its an easy fix

SHA found to be messing the attestation test when working with accelerator

until the accelerator issue is settled no taking chances for sporadic possible failures

LMESTM · 2019-03-14T09:15:01Z

Before such a PR is proposed, could there be an issue in the first place that describes the problem and how to reproduce it ?

0xc0170 · 2019-03-14T09:33:23Z

Before such a PR is proposed, could there be an issue in the first place that describes the problem and how to reproduce it ?

Good point, should have tracking issue.

Might be better to remove the lines completely rather to comment them out. Once fixed, the commit would be reverted and they are back.

Removing something needs a reason in the commit msg - why is this being removed. "possible issues" is not sufficient explanation for removal.
Referencing tracking issue in the commit would be nice to have.

0xc0170

Comment above ^^

mbed-ci · 2019-03-14T09:54:22Z

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

alekshex · 2019-03-14T11:09:51Z

Hi @0xc0170,
Issue created: #10095
Defines are removed entirely from file

alekshex · 2019-03-14T11:37:09Z

Please note, apparently this problem was already discovered previously here #6545
and there was a partial workaround merged before into mbedOS #8142

So this is something reoccurring.
@ARMmbed/team-st-mcd

0xc0170

One last thing, if you can amend your last commit - add reason why is this being removed (what it's described in the issue) or just reference there the issue

0xc0170 · 2019-03-14T13:31:16Z

As soon as commit msg is updated, will go into CI

netanelgonen

Seems this is a good workaround for an old issue

… issue: ARMmbed#10095

alekshex · 2019-03-14T15:06:41Z

As soon as commit msg is updated, will go into CI

done

mbed-ci · 2019-03-14T16:26:38Z

Test run: FAILED

Summary: 1 of 9 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-GCC_ARM

alekshex · 2019-03-14T16:48:36Z

looks like Jenkins issue:
https://mbed-os.mbedcloudtesting.com/job/mbed-os-ci_build-GCC_ARM/1885/console

Loading library mbed-os-ci@master
java.io.FileNotFoundException: https://api.github.com/repos/ARMmbed/mbed-os-ci
at com.squareup.okhttp.internal.huc.HttpURLConnectionImpl.getInputStream(HttpURLConnectionImpl.java:243)
at com.squareup.okhttp.internal.huc.DelegatingHttpsURLConnection.getInputStream(DelegatingHttpsURLConnection.java:210)
at com.squareup.okhttp.internal.huc.HttpsURLConnectionImpl.getInputStream(HttpsURLConnectionImpl.java:25)
at org.kohsuke.github.Requester.parse(Requester.java:617)
at org.kohsuke.github.Requester.parse(Requester.java:599)
at org.kohsuke.github.Requester._to(Requester.java:277)
Caused: org.kohsuke.github.GHFileNotFoundException: {
"message": "Server Error"
}

cmonr · 2019-03-14T18:28:31Z

CI restarted

mbed-ci · 2019-03-14T20:32:35Z

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 3
Build artifacts

alekshex mentioned this pull request Mar 13, 2019

remove PSA &crypto for UBLOX_EVK_ODIN_W2 #10087

Closed

ciarmcom requested review from netanelgonen, NirSonnenschein, Patater and a team March 13, 2019 18:00

ciarmcom added the needs: review label Mar 13, 2019

cmonr added the release-version: 5.12.0-rc3 label Mar 13, 2019

NirSonnenschein approved these changes Mar 13, 2019

View reviewed changes

0xc0170 requested review from a team March 13, 2019 22:50

netanelgonen suggested changes Mar 14, 2019

View reviewed changes

Alonof reviewed Mar 14, 2019

View reviewed changes

yanesca approved these changes Mar 14, 2019

View reviewed changes

0xc0170 requested changes Mar 14, 2019

View reviewed changes

0xc0170 added needs: work and removed needs: review labels Mar 14, 2019

0xc0170 approved these changes Mar 14, 2019

View reviewed changes

netanelgonen approved these changes Mar 14, 2019

View reviewed changes

alekshex force-pushed the master branch from 57bfb75 to 1abb867 Compare March 14, 2019 14:23

Temporary disable Crypto HW accelerator on STM32F439xI chipset due to…

f976ce3

… issue: ARMmbed#10095

alekshex force-pushed the master branch from 1abb867 to f976ce3 Compare March 14, 2019 15:04

cmonr added needs: CI and removed needs: work labels Mar 14, 2019

cmonr merged commit 0861709 into ARMmbed:master Mar 15, 2019

cmonr removed the needs: CI label Mar 15, 2019

jeromecoutant mentioned this pull request Mar 24, 2020

STM32F4 update drivers version to CUBE V1.25.0 #12626

Merged

jeromecoutant mentioned this pull request Apr 2, 2020

Incorrect behavior working with Crypto HW accelerator on STM32F439xI chipset #10095

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Temporary disable Crypto HW accelerator on UBLOX_EVK_ODIN_W2 #10088

Temporary disable Crypto HW accelerator on UBLOX_EVK_ODIN_W2 #10088

alekshex commented Mar 13, 2019 •

edited

Loading

Patater commented Mar 13, 2019

alekshex commented Mar 13, 2019 •

edited

Loading

ciarmcom commented Mar 13, 2019

NirSonnenschein commented Mar 13, 2019

NirSonnenschein commented Mar 13, 2019

NirSonnenschein commented Mar 14, 2019

netanelgonen left a comment

Alonof Mar 14, 2019

alekshex Mar 14, 2019

alekshex Mar 14, 2019

LMESTM commented Mar 14, 2019

0xc0170 commented Mar 14, 2019 •

edited

Loading

0xc0170 left a comment

mbed-ci commented Mar 14, 2019

alekshex commented Mar 14, 2019

alekshex commented Mar 14, 2019

0xc0170 left a comment

0xc0170 commented Mar 14, 2019

netanelgonen left a comment

alekshex commented Mar 14, 2019

mbed-ci commented Mar 14, 2019

alekshex commented Mar 14, 2019

cmonr commented Mar 14, 2019

mbed-ci commented Mar 14, 2019


		#define MBEDTLS_SHA1_ALT
		//#define MBEDTLS_SHA1_ALT

Temporary disable Crypto HW accelerator on UBLOX_EVK_ODIN_W2 #10088

Temporary disable Crypto HW accelerator on UBLOX_EVK_ODIN_W2 #10088

Conversation

alekshex commented Mar 13, 2019 • edited Loading

Description

Pull request type

Reviewers

Release Notes

Patater commented Mar 13, 2019

alekshex commented Mar 13, 2019 • edited Loading

ciarmcom commented Mar 13, 2019

NirSonnenschein commented Mar 13, 2019

NirSonnenschein commented Mar 13, 2019

NirSonnenschein commented Mar 14, 2019

netanelgonen left a comment

Choose a reason for hiding this comment

Alonof Mar 14, 2019

Choose a reason for hiding this comment

alekshex Mar 14, 2019

Choose a reason for hiding this comment

alekshex Mar 14, 2019

Choose a reason for hiding this comment

LMESTM commented Mar 14, 2019

0xc0170 commented Mar 14, 2019 • edited Loading

0xc0170 left a comment

Choose a reason for hiding this comment

mbed-ci commented Mar 14, 2019

Test run: SUCCESS

alekshex commented Mar 14, 2019

alekshex commented Mar 14, 2019

0xc0170 left a comment

Choose a reason for hiding this comment

0xc0170 commented Mar 14, 2019

netanelgonen left a comment

Choose a reason for hiding this comment

alekshex commented Mar 14, 2019

mbed-ci commented Mar 14, 2019

Test run: FAILED

alekshex commented Mar 14, 2019

cmonr commented Mar 14, 2019

mbed-ci commented Mar 14, 2019

Test run: SUCCESS

alekshex commented Mar 13, 2019 •

edited

Loading

alekshex commented Mar 13, 2019 •

edited

Loading

0xc0170 commented Mar 14, 2019 •

edited

Loading