Fix MBED_RAM_START/MBED_RAM_SIZE symbol generation #10008

ccli8 · 2019-03-08T10:27:31Z

Description

This PR tries to fix #9716 with build tool-generated MBED_RAM_START/MBED_RAM_SIZE symbols passed to C/C++ and linker files. It has the effects:

Fix MBED_RAM_START/MBED_RAM_SIZE symbols are not passed to C/C++ file (see build tool-generated .profile-c/.profile-cxx) when there are target.mbed_ram_start/target.mbed_ram_size overrides.
Avoid duplicate MBED_RAM_START/MBED_RAM_SIZE symbols passed to linker file (see build tool-generated .profile-ld).

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Related issue or PR

#10004
#9716

ciarmcom · 2019-03-08T12:00:28Z

@ccli8, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

theotherjimmy · 2019-03-08T14:50:24Z

tools/toolchains/mbed_toolchain.py

@@ -872,7 +872,7 @@ def add_regions(self):
                    "s" if len(regions) > 1 else "",
                    ", ".join(r.name for r in regions)
                ))
-                self._add_all_regions(regions, "MBED_RAM")
+                self._add_all_regions(regions, "MBED_RAM_APP")


I'm not keen to make this change yet. While we certainly will get to a point where we have application's ram separated from physical ram, we have no configuration for that use right now. Your proposal to use mbed_ram_start and mbed_ram_size for this purpose will:

Break any project that depends on those configuration settings current behavior.

Be inconsistent with mbed_rom_start and mbed_rom_size

This is to fix duplicate MBED_RAM_START symbol in .profile-ld. Would you point out another solution to it?

theotherjimmy · 2019-03-08T14:54:21Z

Based on the description in #9716 I would expect this PR to rename the C flag APPLICAITON_RAM_START to MBED_RAM_START.

ccli8 · 2019-03-09T02:22:15Z

@theotherjimmy Please correct me for my understanding:

target.mbed_ram_start is for overriding physical ram from cmsis pack memory spec, just like target.mbed_rom_start is for physical rom.
Currently, there's no target.mbed_ram_app_start configuration option to override application ram.
MBED_RAM_START is generated from cmsis pack memory spec or target.mbed_ram_start override and means physical ram start.

Then to address #9716, how to make MBED_RAM_START symbol available both to c/c++ and linker files and avoid duplicate?

theotherjimmy · 2019-03-09T19:19:02Z

@ccli8 I would do something like:

remove the if block from 868 - 877
expand the memory list in 885 to include RAM defines.

Does that help?

ccli8 · 2019-03-11T05:32:40Z

@theotherjimmy Follow your suggestion but implement with another approach by skipping duplicate MBED_RAM_START in .profile-ld.

theotherjimmy · 2019-03-11T13:44:27Z

@ccli8 Could you update the PR description to reflect the affects of this PR? Nice diff BTW. Clever.

theotherjimmy · 2019-03-11T13:53:13Z

@ccli8 Reading through the related code, I think this may have the unintended side affect of never passing CMSIS defined RAM to the linker. Sorry for being blunt, I can't think of a better way of wording this right now. How have you tested this?

ccli8 · 2019-03-12T02:25:35Z

I think this may have the unintended side affect of never passing CMSIS defined RAM to the linker

@theotherjimmy To verify it, I check build-tool generated symbols in .profile-c and .profile-ld:

When there are no target.mbed_ram_start/target.mbed_ram_size overrides, MBED_RAM_START/MBED_RAM_SIZE reflect CMSIS defined RAM.
When there are target.mbed_ram_start/target.mbed_ram_size overrides, MBED_RAM_START/MBED_RAM_SIZE reflect these RAM overrides.
MBED_RAM_START/MBED_RAM_SIZE are always generated in both .profile-c and .profile-ld.
MBED_RAM_START/MBED_RAM_SIZE are not duplicate in both .profile-c and .profile-ld.

ccli8 · 2019-03-12T02:43:40Z

Could you update the PR description to reflect the affects of this PR?

@theotherjimmy Update done

theotherjimmy

Diff looks great. Thanks!

0xc0170 · 2019-03-16T05:28:12Z

Needs rebase

ccli8 · 2019-03-18T01:19:25Z

@0xc0170 Rebase done

0xc0170 · 2019-03-18T08:06:48Z

CI started

mbed-ci · 2019-03-18T10:25:24Z

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

0xc0170 · 2019-03-20T14:43:05Z

@ccli8 Can you please rebase? Latest PR to the tools (fix) created this conflict. sorry about that, should move to CI asap and merge.

ccli8 · 2019-03-21T01:32:36Z

@0xc0170 Rebase done

0xc0170 · 2019-03-21T11:09:15Z

CI restarted

mbed-ci · 2019-03-21T12:03:14Z

Test run: FAILED

Summary: 6 of 9 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_mbed2-build-GCC_ARM
jenkins-ci/mbed-os-ci_mbed2-build-ARMC5
jenkins-ci/mbed-os-ci_build-ARMC6
jenkins-ci/mbed-os-ci_build-GCC_ARM
jenkins-ci/mbed-os-ci_mbed2-build-IAR8
jenkins-ci/mbed-os-ci_build-IAR8

alekla01 · 2019-03-21T12:03:57Z

CI Restarted

mbed-ci · 2019-03-21T14:20:59Z

Test run: FAILED

Summary: 1 of 13 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_greentea-test

0xc0170 · 2019-03-21T14:43:22Z

io serial for one device (networking tests), will restart

0xc0170 · 2019-03-22T05:38:57Z

@ccli8 Let's wait until we finalize rc4 , to avoid rebasing/CI as we might have another config fix. Will go to CI as soon as 5.12 rc4 is completed. Sorry about it, this week landed lot of fixes to config for 5.12.0 resulting in conflicts with this PR.

cmonr · 2019-03-25T19:29:04Z

Rebase when able. RC4 has since been made and merged.

1. Fix MBED_RAM_START/MBED_RAM_SIZE are not generated when there are target.mbed_ram_start/target.mbed_ram_size overrides 2. Fix MBED_RAM_START/MBED_RAM_SIZE are duplicated.

ccli8 · 2019-03-26T01:49:02Z

@cmonr Rebase done.

cmonr · 2019-03-26T02:11:46Z

CI started

mbed-ci · 2019-03-26T06:30:00Z

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 4
Build artifacts

Fix MBED_RAM_START/MBED_RAM_SIZE symbol generation

ccli8 mentioned this pull request Mar 8, 2019

M2351: Support memory custom partition #10004

Merged

ciarmcom requested a review from a team March 8, 2019 12:00

ciarmcom added the needs: review label Mar 8, 2019

theotherjimmy suggested changes Mar 8, 2019

View reviewed changes

ccli8 force-pushed the nuvoton_fix-ram-symbol branch from 6d40abe to 109df24 Compare March 11, 2019 05:23

0xc0170 added the release-version: 5.12.1 label Mar 11, 2019

theotherjimmy approved these changes Mar 12, 2019

View reviewed changes

0xc0170 approved these changes Mar 12, 2019

View reviewed changes

0xc0170 added needs: CI and removed needs: review labels Mar 12, 2019

0xc0170 added needs: work and removed needs: CI labels Mar 16, 2019

ccli8 force-pushed the nuvoton_fix-ram-symbol branch from 109df24 to a235019 Compare March 18, 2019 01:17

0xc0170 added needs: CI and removed needs: work labels Mar 18, 2019

0xc0170 added the ready for merge label Mar 18, 2019

ccli8 force-pushed the nuvoton_fix-ram-symbol branch from a235019 to 39e92f8 Compare March 21, 2019 01:31

0xc0170 added needs: CI and removed needs: work labels Mar 21, 2019

ccli8 mentioned this pull request Mar 21, 2019

Inconsistent symbol generation with target.mbed_ram_start override #9716

Closed

0xc0170 added ready for merge needs: work and removed needs: CI ready for merge labels Mar 21, 2019

Fix MBED_RAM_START/MBED_RAM_SIZE symbol generation

da7035e

1. Fix MBED_RAM_START/MBED_RAM_SIZE are not generated when there are target.mbed_ram_start/target.mbed_ram_size overrides 2. Fix MBED_RAM_START/MBED_RAM_SIZE are duplicated.

ccli8 force-pushed the nuvoton_fix-ram-symbol branch from 39e92f8 to da7035e Compare March 26, 2019 01:37

cmonr added needs: CI and removed needs: work labels Mar 26, 2019

NirSonnenschein added ready for merge and removed needs: CI labels Mar 26, 2019

cmonr pushed a commit to cmonr/mbed-os that referenced this pull request Mar 26, 2019

Merge pull request ARMmbed#10008 from OpenNuvoton/nuvoton_fix-ram-symbol

860001e

Fix MBED_RAM_START/MBED_RAM_SIZE symbol generation

cmonr merged commit a6c9c8c into ARMmbed:master Mar 27, 2019

cmonr removed the ready for merge label Mar 27, 2019

ccli8 deleted the nuvoton_fix-ram-symbol branch March 27, 2019 05:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix MBED_RAM_START/MBED_RAM_SIZE symbol generation #10008

Fix MBED_RAM_START/MBED_RAM_SIZE symbol generation #10008

ccli8 commented Mar 8, 2019 •

edited

Loading

ciarmcom commented Mar 8, 2019

theotherjimmy Mar 8, 2019

ccli8 Mar 9, 2019

theotherjimmy commented Mar 8, 2019 •

edited

Loading

ccli8 commented Mar 9, 2019

theotherjimmy commented Mar 9, 2019

ccli8 commented Mar 11, 2019

theotherjimmy commented Mar 11, 2019

theotherjimmy commented Mar 11, 2019

ccli8 commented Mar 12, 2019 •

edited

Loading

ccli8 commented Mar 12, 2019

theotherjimmy left a comment

0xc0170 commented Mar 16, 2019

ccli8 commented Mar 18, 2019

0xc0170 commented Mar 18, 2019

mbed-ci commented Mar 18, 2019

0xc0170 commented Mar 20, 2019 •

edited

Loading

ccli8 commented Mar 21, 2019

0xc0170 commented Mar 21, 2019

mbed-ci commented Mar 21, 2019

alekla01 commented Mar 21, 2019

mbed-ci commented Mar 21, 2019

0xc0170 commented Mar 21, 2019

0xc0170 commented Mar 22, 2019

cmonr commented Mar 25, 2019

ccli8 commented Mar 26, 2019

cmonr commented Mar 26, 2019

mbed-ci commented Mar 26, 2019

Fix MBED_RAM_START/MBED_RAM_SIZE symbol generation #10008

Fix MBED_RAM_START/MBED_RAM_SIZE symbol generation #10008

Conversation

ccli8 commented Mar 8, 2019 • edited Loading

Description

Pull request type

Related issue or PR

ciarmcom commented Mar 8, 2019

theotherjimmy Mar 8, 2019

Choose a reason for hiding this comment

ccli8 Mar 9, 2019

Choose a reason for hiding this comment

theotherjimmy commented Mar 8, 2019 • edited Loading

ccli8 commented Mar 9, 2019

theotherjimmy commented Mar 9, 2019

ccli8 commented Mar 11, 2019

theotherjimmy commented Mar 11, 2019

theotherjimmy commented Mar 11, 2019

ccli8 commented Mar 12, 2019 • edited Loading

ccli8 commented Mar 12, 2019

theotherjimmy left a comment

Choose a reason for hiding this comment

0xc0170 commented Mar 16, 2019

ccli8 commented Mar 18, 2019

0xc0170 commented Mar 18, 2019

mbed-ci commented Mar 18, 2019

Test run: SUCCESS

0xc0170 commented Mar 20, 2019 • edited Loading

ccli8 commented Mar 21, 2019

0xc0170 commented Mar 21, 2019

mbed-ci commented Mar 21, 2019

Test run: FAILED

alekla01 commented Mar 21, 2019

mbed-ci commented Mar 21, 2019

Test run: FAILED

0xc0170 commented Mar 21, 2019

0xc0170 commented Mar 22, 2019

cmonr commented Mar 25, 2019

ccli8 commented Mar 26, 2019

cmonr commented Mar 26, 2019

mbed-ci commented Mar 26, 2019

Test run: SUCCESS

ccli8 commented Mar 8, 2019 •

edited

Loading

theotherjimmy commented Mar 8, 2019 •

edited

Loading

ccli8 commented Mar 12, 2019 •

edited

Loading

0xc0170 commented Mar 20, 2019 •

edited

Loading